535903 - [SeaMonkey 2.1] mochitest-browser-chrome: "browser_focus_steal_from_chrome.js | Timed out"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20091218 SeaMonkey/2.1a1pre] (home, optim default) (W2Ksp4)

Comment 1

[Serge Gautherie (:sgautherie)]

{
Console message: [JavaScript Error: "BrowserSearch is not defined" {file: "chrome://mochikit/content/browser/dom/tests/browser/browser_focus_steal_from_chrome.js" line: 133}]

Console message: [JavaScript Error: "BrowserSearch is not defined" {file: "chrome://mochikit/content/browser/dom/tests/browser/browser_focus_steal_from_chrome.js" line: 149}]

Timed out
}

Comment 2

[Philip Chee]

SeaMonkey does not have a search bar.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Why are the "browser" tests shared between different products??

Comment 4

[Philip Chee]

I think these are actually DOM tests that just happen to use the browser for test purposes.

SeaMonkey specific browser tests are in [comm-central]/suite/browser/tests/
Firefox specific browser tests are in [mozilla-central]/browser/*/tests/

Comment 5

[Boris Zbarsky [:bzbarsky]]

That's correct.  Things that are in dom/ are supposed to be testing universal DOM functionality.

Comment 6

[Boris Zbarsky [:bzbarsky]]

And a "steal focus from chrome" test does sound like it should live in dom/

Comment 7

[Robert Kaiser]

Then it would be good if the test would be done with some element that is at visible in both browsers running those tests or it should fail gracefully (possibly with a TODO) when the element to test with isn't found in the first place.

Comment 8

[Serge Gautherie (:sgautherie)]

Linux and MacOSX too:
{
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1266802111.1266803198.17758.gz
Linux comm-central-trunk debug test mochitest-other on 2010/02/21 17:28:31

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1266802005.1266803746.19182.gz
OS X 10.5 comm-central-trunk debug test xpcshell on 2010/02/21 17:26:45
}

Comment 9

[Serge Gautherie (:sgautherie)]

Bug still there.
Masayuki, what's the plan to solve this?

Comment 10

[Serge Gautherie (:sgautherie)]

And this failure is causing at least the 4 next browser_Browser.js failures (because a tab is left open).

Comment 11

[Johnny Stenback (:jst)]

Not blocking the release on this.

Comment 12

[Ian Neal]

Attachment: Switch to a more generic chrome element patch v0.1 [Checked in: comment 14]

Switches to finding an element with an id urlbar making the test not dependent on code sitting in /browser (i.e. BrowserSearch).
Is test only but asking for a= anyway.

Comment 13

[Ian Neal]

Comment on attachment 472196 [details] [diff] [review]
Switch to a more generic chrome element patch v0.1 [Checked in: comment 14]

As a test a=testing NPODB

Comment 14

[Ian Neal]

Comment on attachment 472196 [details] [diff] [review]
Switch to a more generic chrome element patch v0.1 [Checked in: comment 14]

http://hg.mozilla.org/mozilla-central/rev/fe3a1059a92b