Closed Bug 536089 Opened 15 years ago Closed 15 years ago

nsIMM32Handler.cpp fails to compile on mingw.

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
x86
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

fix
1.01 KB, patch
roc
: review+
Details | Diff | Splinter Review
Attached patch fix — — Splinter Review 
I get following error when compiling on mingw:

/home/jacek/mozilla-build/wine-gecko-git/widget/src/windows/nsIMM32Handler.cpp: In member function 'PRBool nsIMM32Handler::OnMouseEvent(nsWindow*, LPARAM, int)':
/home/jacek/mozilla-build/wine-gecko-git/widget/src/windows/nsIMM32Handler.cpp:1655: error: no matching function for call to 'nsIMM32Handler::ResolveIMECaretPos(nsWindow*&, nsIntRect, nsWindow*, nsIntRect&)'
/home/jacek/mozilla-build/wine-gecko-git/widget/src/windows/nsIMM32Handler.cpp:1610: note: candidates are: void nsIMM32Handler::ResolveIMECaretPos(nsIWidget*, nsIntRect&, nsIWidget*, nsIntRect&)

It's because a temporary nsIntRect is passed to ResolveIMECaretPos as a reference. The fix is to create a real instance first.
Attachment #418572 - Attachment is patch: true
Attachment #418572 - Flags: review?(roc)
Keywords: checkin-needed
Blocks: 421095
Assignee: nobody → jacek
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/ddeed8a12500.
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: