Closed
Bug 536089
Opened 16 years ago
Closed 16 years ago
nsIMM32Handler.cpp fails to compile on mingw.
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
I get following error when compiling on mingw:
/home/jacek/mozilla-build/wine-gecko-git/widget/src/windows/nsIMM32Handler.cpp: In member function 'PRBool nsIMM32Handler::OnMouseEvent(nsWindow*, LPARAM, int)':
/home/jacek/mozilla-build/wine-gecko-git/widget/src/windows/nsIMM32Handler.cpp:1655: error: no matching function for call to 'nsIMM32Handler::ResolveIMECaretPos(nsWindow*&, nsIntRect, nsWindow*, nsIntRect&)'
/home/jacek/mozilla-build/wine-gecko-git/widget/src/windows/nsIMM32Handler.cpp:1610: note: candidates are: void nsIMM32Handler::ResolveIMECaretPos(nsIWidget*, nsIntRect&, nsIWidget*, nsIntRect&)
It's because a temporary nsIntRect is passed to ResolveIMECaretPos as a reference. The fix is to create a real instance first.
|
Assignee | |
Updated•16 years ago
|
Attachment #418572 -
Attachment is patch: true
Attachment #418572 -
Flags: review?(roc)
Attachment #418572 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Updated•16 years ago
|
Assignee: nobody → jacek
|
||
Comment 1•16 years ago
|
||
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/ddeed8a12500.
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•