Omnibus ad-blocking bug for January 2010

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: alqahira, Assigned: alqahira)

Tracking

({fixed1.8.1.24})

unspecified
All
Mac OS X
fixed1.8.1.24
Bug Flags:
camino1.6.11 +
camino2.0.2 +

Details

(Whiteboard: [camino-2.0.2])

Attachments

(1 attachment)

Old MacDonald had an ad, e-i-e-i-o…
On http://www.macworld.com/search.html?cx=003198751674731024891%3Aovffo1orlum&q=Camino&client=idg-cse&cof=FORID%3A11#1078

iframe[name="googleSearchFrame"] ?

(Macworld, and cbo, and others instead use a generic <table> that's impossible to block :( )
Heaven help us if any of our users are getting their software from Softpedia, but in the event they are, there are ads in the sidebar, e.g. http://mac.softpedia.com/get/Internet-Utilities/Troubleshoot-Camino.shtml :P

td[id="first_ad_unit"]
(In reply to comment #1)
> On
> http://www.macworld.com/search.html?cx=003198751674731024891%3Aovffo1orlum&q=Camino&client=idg-cse&cof=FORID%3A11#1078
> 
> iframe[name="googleSearchFrame"] ?

That frame is the entire search results, so no.  The ads inside the frame are a generic <table>, as everywhere else.
On http://www.intellicast.com/Travel/Driving/Highways.aspx?route=I-79 and http://www.intellicast.com/Travel/Driving/Highways.aspx?route=US-77

More Pulse360 ads:

# div id="p360-hybrid300x250doubleround-1AD86C72-C312-11DE-852E-314B3FF5047F"
# div id="p360-format-box"

Other sorts of ads:

# div class : yab-300-ad
# div class : yab-728-ad
# iframe http://d.mediaforceads.com/afr.php?n=a8783916&zon eid=17&cb=0.23973232891335827
# embed src : http://cdn.optmd.com/
# embed[src*="xx.openx.com"]
# img[src*="xx.openx.com"]

Also, on wsbtv.com:

* div id="p360-hybrid728x90aquanotch-2A8D7710-89AD-11DD-A9A2-D97F3FF5047F"
* div id : p360-format-box
* embed src : http://im.afy11.net/images/03/30/1000003307718.swf
Created attachment 424442 [details] [diff] [review]
Jan 2010 Omnibus Ads

This fixes all of these, except the obvious Google search issue mentioned above.

In the embed section, I removed a stray trailing space on the mixi.jp rule, and I also consolidated a specific tradedoubler rule into a more generic one we had added later.

For p360, the new rules were also going to be of the ^"p360-foo" format, so I consolidated with the existing one (the issue with p360 before was "p360", so the "-" should be good enough to prevent that, as the "_" is in related rules).
Assignee: nobody → alqahira
Status: NEW → ASSIGNED
Attachment #424442 - Flags: superreview?(stuart.morgan+bugzilla)

Comment 7

9 years ago
Comment on attachment 424442 [details] [diff] [review]
Jan 2010 Omnibus Ads

sr=smorgan
Attachment #424442 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Landed on cvs trunk.

Depending on how long this has been in before we build, we might take this for 2.0.2 and/or 1.6.11.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: camino2.0.2?
Flags: camino1.6.11?
Resolution: --- → FIXED
This has been in nearly two weeks now with nary a regression raised, so landing on the CAMINO_2_0_BRANCH for 2.0.2
Flags: camino2.0.2? → camino2.0.2+
Whiteboard: [camino-2.0.2]
Landed on the MOZILLA_1_8_BRANCH in advance of Camino 1.6.11.
Flags: camino1.6.11? → camino1.6.11+
Keywords: fixed1.8.1.24
You need to log in before you can comment on or make changes to this bug.