536125 - Omnibus ad-blocking bug for January 2010

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Old MacDonald had an ad, e-i-e-i-o…

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www.macworld.com/search.html?cx=003198751674731024891%3Aovffo1orlum&q=Camino&client=idg-cse&cof=FORID%3A11#1078

iframe[name="googleSearchFrame"] ?

(Macworld, and cbo, and others instead use a generic <table> that's impossible to block :( )

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Heaven help us if any of our users are getting their software from Softpedia, but in the event they are, there are ads in the sidebar, e.g. http://mac.softpedia.com/get/Internet-Utilities/Troubleshoot-Camino.shtml :P

td[id="first_ad_unit"]

Comment 3

[philippe (part-time)]

As reported in the forums
(http://forums.mozillazine.org/viewtopic.php?f=12&t=1720375)

small ads on the NYT (frontpage), from linkstorm.net

<a href="http://click.linkstorm.net/click/ATLS/NYTJ/D700/ff80808225dc55e501264d80cb1b009a/click?2010.01.28.07.07.14&amp;type=alt" target="_blank"><img src="http://img.linkstorm.net/images/atls/nytj/d700/2010.01.28.07.07.14/altbasemedia/NYTbanner_Still.jpg" width="163" height="90" border="0" alt=""></a>

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #1)
> On
> http://www.macworld.com/search.html?cx=003198751674731024891%3Aovffo1orlum&q=Camino&client=idg-cse&cof=FORID%3A11#1078
> 
> iframe[name="googleSearchFrame"] ?

That frame is the entire search results, so no.  The ads inside the frame are a generic <table>, as everywhere else.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www.intellicast.com/Travel/Driving/Highways.aspx?route=I-79 and http://www.intellicast.com/Travel/Driving/Highways.aspx?route=US-77

More Pulse360 ads:

# div id="p360-hybrid300x250doubleround-1AD86C72-C312-11DE-852E-314B3FF5047F"
# div id="p360-format-box"

Other sorts of ads:

# div class : yab-300-ad
# div class : yab-728-ad
# iframe http://d.mediaforceads.com/afr.php?n=a8783916&zon eid=17&cb=0.23973232891335827
# embed src : http://cdn.optmd.com/
# embed[src*="xx.openx.com"]
# img[src*="xx.openx.com"]

Also, on wsbtv.com:

* div id="p360-hybrid728x90aquanotch-2A8D7710-89AD-11DD-A9A2-D97F3FF5047F"
* div id : p360-format-box
* embed src : http://im.afy11.net/images/03/30/1000003307718.swf

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Jan 2010 Omnibus Ads

This fixes all of these, except the obvious Google search issue mentioned above.

In the embed section, I removed a stray trailing space on the mixi.jp rule, and I also consolidated a specific tradedoubler rule into a more generic one we had added later.

For p360, the new rules were also going to be of the ^"p360-foo" format, so I consolidated with the existing one (the issue with p360 before was "p360", so the "-" should be good enough to prevent that, as the "_" is in related rules).

Comment 7

[Stuart Morgan]

Comment on attachment 424442 [details] [diff] [review]
Jan 2010 Omnibus Ads

sr=smorgan

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.

Depending on how long this has been in before we build, we might take this for 2.0.2 and/or 1.6.11.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This has been in nearly two weeks now with nary a regression raised, so landing on the CAMINO_2_0_BRANCH for 2.0.2

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the MOZILLA_1_8_BRANCH in advance of Camino 1.6.11.