Last Comment Bug 536137 - wrappedJSObject hides "next" property
: wrappedJSObject hides "next" property
Status: RESOLVED FIXED
[firebug-p2][3.6.x]
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: 1.9.2 Branch
: x86 Windows XP
: -- normal (vote)
: ---
Assigned To: Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-21 01:49 PST by Jan Honza Odvarko [:Honza]
Modified: 2010-03-13 20:30 PST (History)
3 users (show)
mbeltzner: blocking1.9.2-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix (2.86 KB, patch)
2009-12-21 15:42 PST, Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017)
jst: review+
Details | Diff | Splinter Review

Description Jan Honza Odvarko [:Honza] 2009-12-21 01:49:25 PST
One reported problem in Firebug
http://code.google.com/p/fbug/issues/detail?id=2580

...says that an object's property labeled "next" is not visible in the DOM panel.

After digging into the problem I have found that if a JS object defined on a page eg:

var a = {a:1, b:2, next:3};

... is accessed from chrome using wrappedJSObject, the "next" property is not visible when iterating properties using for-in loop. 

Test case here:
http://getfirebug.com/tests/content/dom/2580/issue2580.html

Firebug 1.5b8 here:
http://getfirebug.com/releases/firebug/1.5X/

Honza
Comment 1 Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2009-12-21 15:42:41 PST
Created attachment 418736 [details] [diff] [review]
Fix

By adding the 'next' function after we grab the snapshot of the iterator's properties, we avoid this.
Comment 2 John J. Barton 2010-01-06 15:55:30 PST
Requesting blocking to get this evaluated for risk and on some list to get in a release
Comment 3 Mike Beltzner [:beltzner, not reading bugmail] 2010-01-11 08:58:53 PST
Can someone please respond to comment 2? I'm guessing that this is not a blocker and a good target for a 3.6.x release, so marking in the whiteboard with that tag.
Comment 4 Mike Beltzner [:beltzner, not reading bugmail] 2010-01-11 16:23:21 PST
Blake caught me on IRC and said that this was low-risk and low-impact enough that we could take it on the branch after we ship. Not blocking, but marked for branch update attention.
Comment 5 Blake Kaplan (:mrbkap) (PTO until Jan. 2, 2017) 2010-03-13 20:30:41 PST
http://hg.mozilla.org/mozilla-central/rev/050abb8ffcd7

Note You need to log in before you can comment on or make changes to this bug.