536137 - wrappedJSObject hides "next" property

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

One reported problem in Firebug
http://code.google.com/p/fbug/issues/detail?id=2580

...says that an object's property labeled "next" is not visible in the DOM panel.

After digging into the problem I have found that if a JS object defined on a page eg:

var a = {a:1, b:2, next:3};

... is accessed from chrome using wrappedJSObject, the "next" property is not visible when iterating properties using for-in loop. 

Test case here:
http://getfirebug.com/tests/content/dom/2580/issue2580.html

Firebug 1.5b8 here:
http://getfirebug.com/releases/firebug/1.5X/

Honza

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

By adding the 'next' function after we grab the snapshot of the iterator's properties, we avoid this.

Comment 2

[John J. Barton]

Requesting blocking to get this evaluated for risk and on some list to get in a release

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Can someone please respond to comment 2? I'm guessing that this is not a blocker and a good target for a 3.6.x release, so marking in the whiteboard with that tag.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Blake caught me on IRC and said that this was low-risk and low-impact enough that we could take it on the branch after we ship. Not blocking, but marked for branch update attention.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/050abb8ffcd7