53615 - XHTML title element content not appearing in window title bar

Status: VERIFIED FIXED

(Core :: XML, defect, P3)

Description

[Chris Petersen]

Build: 2000092108
Platforms: All
Expected results: Title content should displayed as window's title
What I got: Title is not displayed in window title bar.
Steps to reproduce:

1) Open attached test cases (title.xml) in N6.
2) Window's title show say "Hello XHTML" but doesn't.

Comment 1

[Chris Petersen]

Attachment: A simple XHTML document with a title element

Comment 2

[Nisheeth Ranjan]

This bug has been marked "future" because the original netscape engineer working
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug, or if it blocks your work in some way
-- please attach your concern to the bug for reconsideration.

Comment 3

[Nisheeth Ranjan]

Marking future...

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I am already owner of related things, taking.

Comment 5

[Chris Petersen]

Noticed that the TITLE element's content is displayed in the browser window now.
Tested with the 2001010908 build.

Comment 6

[Chris Petersen]

Attachment: A xhtml well-formed document with a title element

Comment 7

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Yes, but the bug is that the title does not appear in the title bar. Could you
whip up a minimal regular XML file which has only the title element from the
XHTML namespace?

Comment 8

[Chris Petersen]

Oops, pilot error .. Forget about the issue of the title's content being
displayed in the window. I misspelled namespace as "xnlns" in the root element.
When this was corrected to "xmlns", the text is no longer appearing in the browser.

Comment 9

[Chris Petersen]

Attachment: A simple xhtml document with title element

Comment 10

[Chris Petersen]

Using xhtml namespace, the title element is not rendered correctly either. Title
of window is using contents of title element.

Comment 11

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Hmm, this is actually a dupe...

*** This bug has been marked as a duplicate of 36790 ***

Comment 12

[Robin Lionheart]

36790 is about <style> elements in XHTML documents, this is about <title> elements. They may be related and/or dependent, but a duplicate?

Comment 13

[Heikki Toivonen (remove -bugzilla when emailing directly)]

*blush* I knew something weird had happened. I LOST this bug. I guess I must
have read title=style. I'll reopen. Thanks, Robin!

Comment 14

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Proposed fix 1

Comment 15

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I basically copied the way we do the title for HTML documents. It is simpler
than in the HTML case, though (for example we do not save the title in the
document - I do not see a reason for it yet). Basically when we find an XHTML
title element, we start collecting the text and when we see the title close we
set the title for the document (which in turn sets it for the window). This
works even if the title element contains newlines, multiple spaces (whitespace
compressed) and even subelements. The first title element in the document wins
(this should mimic the HTML case).

Comment 16

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Proposed fix 2 (including changes in rdf) and fix for 51815

Comment 17

[harishd]

patch looks good. r=harishd

Comment 18

[vidur (gone)]

Suggested (but not necessary changes):
1) Consider moving the SetTitle method to nsIDocument. If that doesn't seem like
the right place, consider sharing the implementation for nsXMLDocument and
nsHTMLDocument.
2) Consider using the text node created as a child of TITLE and TEXTAREA
elements rather than accumulating separately in the XML content sink.

Otherwise, sr=vidur.
--Vidur

Comment 19

[Heikki Toivonen (remove -bugzilla when emailing directly)]

1) I don't want to move SetTitle() to nsIDocument because not all documents will
want to try and set the window title. Sharing the code between XML and HTML
world does not happen currently - I think it is better to do it in one big
overhaul with content sink refactoring etc. to catch XUL and possibly other
cases as well.
2) The problem with the title/textare child node approach is that it becomes
more difficult if the elements contain subelements/several child nodes. Right,
we do use a little more memory now than we could, but I consider the advantage
of simpler code in this case to win.

Fix checked in.

Comment 20

[Chris Petersen]

Verified fixed in the Feb 05 build (2001020513).