536171 - Large Text Box should have maxlength and wrap => 1 in buglists

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement, P3)

Description

[Christian Höltje]

Large Text Box custom fields should have a maxlength, similar to "Summary (first 60 characters)".  Or at least have an option to choose a short version instead.

Otherwise, adding these columns to your buglist makes the buglist unusable.

Comment 1

[Denis Eperonnier]

This can be solved by changing template

list/table.html.tmpl

you need to add your custom field name (e.g. cf_xxx) to abbrev, and specify limits the same way as for other fields.

In my case this gives:

[% abbrev = 
  {
   .....
  "cf_global_status"  => { maxlength => 200 , ellipsis => "..." , wrap => 1 } ,
  }

Comment 2

[Lalit Khattar]

I want to work on this bug. Can anyone please tell me how to proceed?

Comment 3

[Lalit Khattar]

Attachment: patch_v1.diff

Basically, 'nowrap' class should be used when all the following conditions are met:
1. col_abbrev.wrap attribute is undefined or zero(already present)
2. bug_field.$column.type is not FIELD_TYPE_FREETEXT(added in patch)
3. bug_field.$column.type is not FIELD_TYPE_TEXTAREA(added in patch)

Feel free to suggest any changes in patch.

Thanks,
Lalit

Comment 4

[Frédéric Buclin]

Comment on attachment 8382461 [details] [diff] [review]
patch_v1.diff

>-    <td [% 'class="nowrap"' IF NOT col_abbrev.wrap %]
>+    <td [% 'class="nowrap"' IF NOT col_abbrev.wrap &&
>+          bug_fields.$column.type != constants.FIELD_TYPE_FREETEXT &&
>+          bug_fields.$column.type != constants.FIELD_TYPE_TEXTAREA %]
>         class="bz_[% column FILTER css_class_quote %]_column">

I just realized that <td> has two class="", which is not legal. Please merge them.


Your patch looks good, though, just need to merge both classes. :)

Comment 5

[Lalit Khattar]

Attachment: patch_v2.diff

Merged the two classes and also trucated the TEXTAREA field value with maxlength=>256

Comment 6

[Frédéric Buclin]

Comment on attachment 8382548 [details] [diff] [review]
patch_v2.diff

>+    <td class="bz_[% column FILTER css_class_quote %]_column [% 'nowrap' UNLESS

You should move [% 'nowrap' to its own line. This can be fixed on checkin.


Ideally, the full text should be in title="..." as we do with other truncated fields, but as the text can be quite huge, maybe that's not needed. So r=LpSolit

Comment 7

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/list/table.html.tmpl
Committed revision 8938.