536225 - [shared module] Need a way to cancel all active downloads (DownloadsAPI)

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

In the DownloadsAPI, we do not have a way to cancel active downloads.  cleanUp() only acts on inactive downloads and deleteDownloadedFiles() only acts on files.
Currently, there is no method for canceling a download.  This should be integrated into our cleanUp() process as just doing delete and cleanup in teardownModule will result in a single active download remaining.

Naturally, I have a fix for this.  I'll post a minimized test case and a patch shortly.

Comment 1

[u279076]

Attachment: Minimized test case

Here is a "minimized" test case.  I say that in quotes because it includes a few methods copied from the DownloadsAPI.  This way you can just copy and paste into the Mozmill IDE and run it (no importing of modules necessary).

I left out dm.close() from this test so you can see the state of the Download Manager prior to closing.  As you can see, the download is still active because it was never canceled, and active downloads are not taken care of with dm.cleanUp() -- clearly stated in the nsIDownloadManager API: https://developer.mozilla.org/en/NsIDownloadManager#cleanUp.28.29

Comment 2

[u279076]

Attachment: Initial Patch

Here is the patch to add a cancelActiveDownloads() method to the DownloadsAPI.  I suggest a follow up patch to this to possibly call this method from within the dm.cleanUp() method.

Comment 3

[u279076]

A quick reminder for myself...I'll add API documentation for this method if/when the patch is checked in.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 418701 [details] [diff] [review]
Initial Patch

Looks good so far. I will just make two little changes here. We can use Ci instead of Components.interfaces and a better variable name would be nice. Checkin upcoming.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 418701 [details] [diff] [review]
Initial Patch

>+  var enum = this._dms.activeDownloads;

Oh, and enum should not be used.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/35d158df548e
http://hg.mozilla.org/qa/mozmill-tests/rev/eaf4af799781

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Docs are complete:
https://developer.mozilla.org/en/Mozmill_Tests/Shared_Modules/DownloadsAPI/downloadManager

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.