Closed Bug 536303 Opened 10 years ago Closed 10 years ago

[OOPP] Loading any page with flash with dom.ipc.plugins.enabled = true crashes on Windows 2000

Categories

(Core :: Plug-ins, defect)

x86
Windows 2000
defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: tnikkel, Assigned: jimm)

References

Details

(Whiteboard: [fixed-lorentz])

Attachments

(1 file, 1 obsolete file)

Loading any page with flash (eg a youtube video page) with dom.ipc.plugins.enabled = true crashes on Windows 2000. Tested with latest nightly (2009-12-21) and fresh profile.

Crash report: http://crash-stats.mozilla.com/report/index/b6c88904-5ef7-476a-8f17-6525e2091221
Since RtlGenRandom() is only available from Windows XP.  If we should support IPC for Windows 2000, we need emulate this function for 2000 support.
Summary: Loading any page with flash with dom.ipc.plugins.enabled = true crashes on Windows 2000 → [OOPP] Loading any page with flash with dom.ipc.plugins.enabled = true crashes on Windows 2000
As much as I would like to drop support for Win2k, if we're going to do OOPP as a minor update to Firefox 3.6 we don't want to bump version requirements. The easiest solution here is probably just to not to OOPP on Win2k. jmathies, can you implement that?
Blocks: OOPP
No longer blocks: 531142
Whoops, hit enter too soon. The code which decides whether to use plugin processes is OOPPluginsEnabled in nsNPAPIPlugin.cpp.
Assignee: nobody → jmathies
Attached patch disable oopp on 2k or less (obsolete) — Splinter Review
Attachment #419579 - Flags: review?(benjamin)
Comment on attachment 419579 [details] [diff] [review]
disable oopp on 2k or less

Hrm, this is a lot of XPCOM goop for something which I hoped would be simpler. Is it possible to either use GetVersionEx or PR_GetSystemInfo rather than using system-info+propertybag?
Attachment #419579 - Flags: review?(benjamin) → review-
here we go.
Attachment #419579 - Attachment is obsolete: true
Attachment #420132 - Flags: review?(benjamin)
Attachment #420132 - Flags: review?(benjamin) → review+
http://hg.mozilla.org/mozilla-central/rev/e37603601684

I was going to add this to the tracking wiki page, but for some reason I don't have edit permissions??

https://wiki.mozilla.org/Plugins/OOPP_Branch_Tracking
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
(In reply to comment #7)
> http://hg.mozilla.org/mozilla-central/rev/e37603601684
> 
> I was going to add this to the tracking wiki page, but for some reason I don't
> have edit permissions??
> 
> https://wiki.mozilla.org/Plugins/OOPP_Branch_Tracking

Doh, never mind.
Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed
You need to log in before you can comment on or make changes to this bug.