536303 - [OOPP] Loading any page with flash with dom.ipc.plugins.enabled = true crashes on Windows 2000

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Timothy Nikkel (:tnikkel)]

Loading any page with flash (eg a youtube video page) with dom.ipc.plugins.enabled = true crashes on Windows 2000. Tested with latest nightly (2009-12-21) and fresh profile.

Crash report: http://crash-stats.mozilla.com/report/index/b6c88904-5ef7-476a-8f17-6525e2091221

Comment 1

[Makoto Kato [:m_kato]]

Since RtlGenRandom() is only available from Windows XP.  If we should support IPC for Windows 2000, we need emulate this function for 2000 support.

Comment 2

[Benjamin Smedberg]

As much as I would like to drop support for Win2k, if we're going to do OOPP as a minor update to Firefox 3.6 we don't want to bump version requirements. The easiest solution here is probably just to not to OOPP on Win2k. jmathies, can you implement that?

Comment 3

[Benjamin Smedberg]

Whoops, hit enter too soon. The code which decides whether to use plugin processes is OOPPluginsEnabled in nsNPAPIPlugin.cpp.

Comment 4

[Jim Mathies [:jimm]]

Attachment: disable oopp on 2k or less

Comment 5

[Benjamin Smedberg]

Comment on attachment 419579 [details] [diff] [review]
disable oopp on 2k or less

Hrm, this is a lot of XPCOM goop for something which I hoped would be simpler. Is it possible to either use GetVersionEx or PR_GetSystemInfo rather than using system-info+propertybag?

Comment 6

[Jim Mathies [:jimm]]

Attachment: use getversionex directly

here we go.

Comment 7

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/e37603601684

I was going to add this to the tracking wiki page, but for some reason I don't have edit permissions??

https://wiki.mozilla.org/Plugins/OOPP_Branch_Tracking

Comment 8

[Jim Mathies [:jimm]]

(In reply to comment #7)
> http://hg.mozilla.org/mozilla-central/rev/e37603601684
> 
> I was going to add this to the tracking wiki page, but for some reason I don't
> have edit permissions??
> 
> https://wiki.mozilla.org/Plugins/OOPP_Branch_Tracking

Doh, never mind.

Comment 9

[Benjamin Smedberg]

http://hg.mozilla.org/projects/firefox-lorentz/rev/65467b56515c

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed

Comment 11

[Benjamin Smedberg]

Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430