Closed Bug 536304 Opened 15 years ago Closed 6 years ago

Remove uses of legacy feature switch names (each one has a non-legacy replacement)

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Future

People

(Reporter: edwsmith, Unassigned)

References

Details

Attachments

(1 file, 11 obsolete files)

Remove AVMPLUS_JIT_READONLY
1.07 KB, patch
rreitmai
: review+
Details | Diff | Splinter Review
e.g. AVMPLUS_VERIFYALL -> VMCFG_VERIFYALL a patch per name seems reasonable.
Target Milestone: --- → Future
Assignee: nobody → edwsmith
Attachment #418759 - Flags: review?(rreitmai)
Attachment #418759 - Flags: review?(rreitmai) → review+
Comment on attachment 418759 [details] [diff] [review] AVMPLUS_VERIFYALL -> VMCFG_VERIFYALL pushed http://hg.mozilla.org/tamarin-redux/rev/9878002a1be6
Attachment #418759 - Attachment is obsolete: true
Attached patch FEATURE_NANOJIT -> VMCFG_NANOJIT (obsolete) — — Splinter Review
Attached patch VTUNE -> VMCFG_VTUNE (obsolete) — — Splinter Review
Attached patch AVMPLUS_SYMBIAN -> VMCFG_SYMBIAN (obsolete) — — Splinter Review
Attachment #419133 - Flags: review?(rreitmai)
Attachment #419133 - Flags: review?(rreitmai) → review?(lhansen)
Attachment #419137 - Flags: review?(rreitmai)
Attachment #419138 - Flags: review?(rreitmai)
Attachment #419162 - Flags: review?(stejohns)
Severity: normal → minor
Attachment #419134 - Flags: review?(lhansen)
Attachment #419133 - Flags: review?(lhansen) → review+
Attachment #419135 - Flags: review?(lhansen)
Attachment #419134 - Flags: review?(lhansen) → review+
Attachment #419136 - Flags: review?(lhansen)
Attachment #419135 - Flags: review?(lhansen) → review+
Attachment #419136 - Flags: review?(lhansen) → review+
Comment on attachment 419133 [details] [diff] [review] AVMPLUS_SELFTEST -> VMCFG_SELFTEST pushed http://hg.mozilla.org/tamarin-redux/rev/f7542ba5be91
Attachment #419133 - Attachment is obsolete: true
Comment on attachment 419134 [details] [diff] [review] AVMPLUS_DIRECT_THREADED -> VMCFG_DIRECT_THREADED pushed http://hg.mozilla.org/tamarin-redux/rev/e5c951239cd1
Attachment #419134 - Attachment is obsolete: true
Comment on attachment 419135 [details] [diff] [review] AVMPLUS_PEEPHOLE_OPTIMIZER -> VMCFG_WORDCODE_PEEPHOLE pushed http://hg.mozilla.org/tamarin-redux/rev/ece47861635f
Attachment #419135 - Attachment is obsolete: true
Comment on attachment 419136 [details] [diff] [review] AVMPLUS_WORD_CODE -> VMCFG_WORDCODE pushed http://hg.mozilla.org/tamarin-redux/rev/b979a871c08e
Attachment #419136 - Attachment is obsolete: true
Attachment #419162 - Flags: review?(stejohns) → review+
Comment on attachment 419137 [details] [diff] [review] FEATURE_NANOJIT -> VMCFG_NANOJIT I haven't looked at the TM side of the code, but you might want to make sure that the conversion from FEATURE_ to VMCFG_ doesn't break them, assuming you haven't already done so.
Attachment #419137 - Flags: review?(rreitmai) → review+
Attachment #419138 - Flags: review?(rreitmai) → review+
yeah, i need to split up the patches that modify nanojit.
Blocks: 537926
Direct threaded wordcode interpreter has been broken all this time, because I goofed the #ifdef name when cleaning up legacy feature switches.
Attachment #427886 - Flags: review?(lhansen)
the code in WordcodeEmitter and Interpreter already tested VMCFG_DIRECT_THREADED, but it was never set.
Attachment #427886 - Flags: review?(lhansen) → review+
Comment on attachment 427886 [details] [diff] [review] the direct threading switch should be VMCFG_DIRECT_THREADED, not VMCFG_WORDCODE_THREADED pushed http://hg.mozilla.org/tamarin-redux/rev/f3988f49eea3
Attachment #427886 - Attachment is obsolete: true
Whiteboard: has-patch
Assignee: edwsmith → nobody
Comment on attachment 419162 [details] [diff] [review] AVMPLUS_SYMBIAN -> VMCFG_SYMBIAN TR: http://hg.mozilla.org/tamarin-redux/rev/bda2725fd58a
Attachment #419162 - Attachment is obsolete: true
Assignee: nobody → edwsmith
Rebased. Left nanojit alone for now to avoid having to coordinate changes. Added bug# to each FIXME comment in avmfeatures.as. R+ inherited from first patch.
Attachment #419137 - Attachment is obsolete: true
Attachment #486672 - Flags: review+
Comment on attachment 486672 [details] [diff] [review] (v2) FEATURE_NANOJIT -> VMCFG_NANOJIT http://hg.mozilla.org/tamarin-redux/rev/5e498e4941e8
Attachment #486672 - Attachment is obsolete: true
Attachment #419138 - Attachment is obsolete: true
I grepped FlashRuntime for AVMPLUS_{BIG,LITTLE}_ENDIAN and AVM10_BIG_ENDIAN with no hits. Also, AVM10_BIG_ENDIAN was being defined by AVMSYSTEM_LITTLE_ENDIAN, which seemed wrong. The fact that nothing bad was happening is more evidence that its okay to remove it.
Attachment #487674 - Flags: review?(stejohns)
Attachment #487674 - Flags: feedback?(lhansen)
Attachment #487674 - Flags: review?(stejohns) → review+
Comment on attachment 487674 [details] [diff] [review] Removed uses of legacy ENDIAN defines TR: http://hg.mozilla.org/tamarin-redux/rev/277941dc1120
Comment on attachment 487674 [details] [diff] [review] Removed uses of legacy ENDIAN defines Seems like a good idea.
Attachment #487674 - Flags: feedback?(lhansen) → feedback+
Attachment #487674 - Attachment is obsolete: true
Assignee: edwsmith → nobody
Flags: flashplayer-qrb+
Whiteboard: has-patch
Remaining legacy names: MMGC_64BIT MMGC_IA32 MMGC_AMD64 MMGC_ARM MMGC_PPC MMGC_SPARC AVMPLUS_64BIT AVMPLUS_IA32 AVMPLUS_AMD64 AVMPLUS_ARM AVMPLUS_PPC AVMPLUS_SPARC AVMPLUS_MIPS DEBUGGER AVMPLUS_JIT_READONLY
another one bites the dust
Assignee: nobody → edwsmith
Attachment #568164 - Flags: review?(rreitmai)
Attachment #568164 - Flags: review?(rreitmai) → review+
changeset: 6669:139fbf074457 user: Edwin Smith <edwsmith@adobe.com> summary: Bug 536304 - Remove uses of legacy feature switch names: AVMPLUS_JIT_READONLY (r=rreitmai+) http://hg.mozilla.org/tamarin-redux/rev/139fbf074457
Assignee: edwsmith → nobody
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: