Closed Bug 536408 Opened 16 years ago Closed 15 years ago

Update license blocks to use "Mozilla Foundation" instead of "Mozilla Corporation", comm-central part

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 3.1a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(
URL
)

Details

Attachments

(4 files, 3 obsolete files)

(Av1) /mailnews/* [Checkin: See comment 6]
5.01 KB, patch
dmosedale
: review+
dmosedale
: superreview+
Details | Diff | Splinter Review
(Cv1-SB) /calendar/* [Checkin: See comment 7]
2.17 KB, patch
Details | Diff | Splinter Review
(Bv1b-SM) /suite/* [Checkin: Comment 18]
23.69 KB, patch
gerv
: review+
Details | Diff | Splinter Review
(Dv1a-TB) /mail/* [Checkin: Comment 16]
7.14 KB, patch
dmosedale
: review+
Details | Diff | Splinter Review
No description provided.
Flags: in-testsuite-
Attachment #418868 - Flags: superreview?(dmose)
Attachment #418868 - Flags: superreview?
Attachment #418868 - Flags: review?(dmose)
Attachment #418868 - Flags: review?
Attached patch (Bv1-SM) /suite/* (obsolete) — — Splinter Review
Attachment #418871 - Flags: review?(kairo)
Comment on attachment 418868 [details] [diff] [review] (Av1) /mailnews/* [Checkin: See comment 6] r+sr=dmose; thanks for the patch.
Attachment #418868 - Flags: superreview?(dmose)
Attachment #418868 - Flags: superreview+
Attachment #418868 - Flags: review?(dmose)
Attachment #418868 - Flags: review+
Actually, please change "Mozilla Foundation" to "the Mozilla Foundation" before you check in, unless there's some existing convention that I'm not aware of.
Please take care of calendar too, there are two places. I'd appreciate if you could check this in after review.
Attachment #418876 - Flags: review?(sgautherie.bz)
Comment on attachment 418868 [details] [diff] [review] (Av1) /mailnews/* [Checkin: See comment 6] http://hg.mozilla.org/comm-central/rev/7602c7333e3e Av1, with comment 4 suggestion(s).
Attachment #418868 - Attachment description: (Av1) /mailnews/* → (Av1) /mailnews/* [Checkin: See comment 6]
Comment on attachment 418876 [details] [diff] [review] (Cv1-SB) /calendar/* [Checkin: See comment 7] http://hg.mozilla.org/comm-central/rev/9f173515ca33 Cv1, with comment 4 suggestion(s).
Attachment #418876 - Attachment description: calendar/* → (Cv1-SB) /calendar/* [Checkin: See comment 7]
Attachment #418876 - Flags: review?(sgautherie.bz)
Attached patch (Bv1a-SM) /suite/* (obsolete) — — Splinter Review
Bv1-SM, with comment 4 suggestion(s).
Attachment #418871 - Attachment is obsolete: true
Attachment #418943 - Flags: review?(kairo)
Attachment #418871 - Flags: review?(kairo)
Attached patch (Dv1-TB) /mail/* (obsolete) — — Splinter Review
Attachment #418947 - Flags: review?(dmose)
Comment on attachment 418943 [details] [diff] [review] (Bv1a-SM) /suite/* r- for removing line breaks that are present in the boilerplate on the Mozilla license site, which I'm not sure is a good idea. I still want to have Gerv actually review this as I can't speak for legal issues, and this is nothing but that. Gerv, if my note about r- is wrong from your POV, please feel free to annihilate my review flag.
Attachment #418943 - Flags: review?(kairo)
Attachment #418943 - Flags: review?(gerv)
Attachment #418943 - Flags: review-
Taking out the line breaks isn't great, but it's not a disaster. Parsing scripts can generally cope with either. Serge: when you've finished attaching patches, can you write a summary comment telling me exactly what to review? Gerv
Bv1a-SM, with comment 10 suggestion(s).
Attachment #418943 - Attachment is obsolete: true
Attachment #421256 - Flags: review?(kairo)
Attachment #418943 - Flags: review?(gerv)
Dv1-TB, with comment 10 suggestion(s).
Attachment #418947 - Attachment is obsolete: true
Attachment #421257 - Flags: review?(dmose)
Attachment #418947 - Flags: review?(dmose)
Comment on attachment 421256 [details] [diff] [review] (Bv1b-SM) /suite/* [Checkin: Comment 18] As I said, this is legal stuff, I'd really like Gerv to do this review instead.
Attachment #421256 - Flags: review?(kairo) → review?(gerv)
Comment on attachment 421257 [details] [diff] [review] (Dv1a-TB) /mail/* [Checkin: Comment 16] r=dmose
Attachment #421257 - Flags: review?(dmose) → review+
Comment on attachment 421257 [details] [diff] [review] (Dv1a-TB) /mail/* [Checkin: Comment 16] http://hg.mozilla.org/comm-central/rev/6bff80bb6dcd
Attachment #421257 - Attachment description: (Dv1a-TB) /mail/* → (Dv1a-TB) /mail/* [Checkin: Comment 16]
Comment on attachment 421256 [details] [diff] [review] (Bv1b-SM) /suite/* [Checkin: Comment 18] gerv, ping for review. (see comment 14)
Attachment #421256 - Flags: review?(gerv) → review+
Comment on attachment 421256 [details] [diff] [review] (Bv1b-SM) /suite/* [Checkin: Comment 18] http://hg.mozilla.org/comm-central/rev/49e4963153a2
Attachment #421256 - Attachment description: (Bv1b-SM) /suite/* → (Bv1b-SM) /suite/* [Checkin: Comment 18]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: