Closed
Bug 536520
Opened 16 years ago
Closed 16 years ago
Fix build warning: "'nsNavHistoryResult::mIsAllBookmarksObserver' will be initialized after ... mNeedsToApplySortingMode"
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
1.03 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
Filing this bug to address this compile warning from g++ version 4.3, when building mozilla-central:
> nsNavHistoryResult.h: In constructor ‘nsNavHistoryResult::nsNavHistoryResult(nsNavHistoryContainerResultNode*)’:
> nsNavHistoryResult.h:185: warning: ‘nsNavHistoryResult::mIsAllBookmarksObserver’ will be initialized after
> nsNavHistoryResult.h:175: warning: ‘PRBool nsNavHistoryResult::mNeedsToApplySortingMode’
> nsNavHistoryResult.cpp:4003: warning: when initialized here
The attached patch fixes this by reordering the guilty initialization list to make it match the ordering of declared member variables in the header file. (shifting "mNeedsToApplySortingMode" up a few spots)
Attachment #418974 -
Flags: review?(dietrich)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 418974 [details] [diff] [review]
trivial fix: move |mNeedsToApplySortingMode| earlier in init list
i fixed one but i forgot this :\ thanks.
Attachment #418974 -
Flags: review?(dietrich) → review+
|
|
||
Updated•16 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
|
Assignee | |
Comment 2•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [build_warning]
You need to log in
before you can comment on or make changes to this bug.
Description
•