The default bug view has changed. See this FAQ.

auto sending return receipts does not work

RESOLVED FIXED in Thunderbird 3.1a1

Status

MailNews Core
Composition
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Michiel van Leeuwen (email: mvl+moz@), Assigned: Michiel van Leeuwen (email: mvl+moz@))

Tracking

({fixed-seamonkey2.0.3, regression})

unspecified
Thunderbird 3.1a1
fixed-seamonkey2.0.3, regression

Thunderbird Tracking Flags

(thunderbird3.0 .1-fixed)

Details

Attachments

(1 attachment)

From code inspection:
http://mxr.mozilla.org/comm-central/source/mailnews/extensions/mdn/src/nsMsgMdnGenerator.cpp#362
The receipt will only be send automatically if (1) the return path is empty, and (2) it is equal to the address the receipt should be sent to.
Obviously, both can not hold a the same time. This seems like a conversion error: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mailnews/extensions/mdn/src&command=DIFF_FRAMESET&file=nsMsgMdnGenerator.cpp&rev2=1.21&rev1=1.20 around line 371. The check should be reversed.

Now, I can't test this bug, because my server messes with the return path. So it will never match for me anyway. And I don't know if this should be fixed at all. People might have unknowingly set the pref to autosend, but still got asked to send, because of this bug.
Created attachment 419143 [details] [diff] [review]
patch

This patch should fix it. But see my remarks in comment 0
Attachment #419143 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #419143 - Flags: review? → review?(bienvenu)

Comment 2

7 years ago
this bug was almost certainly introduced in 3.0 so I think fixing it is the right thing to do. Thx for the patch.

Comment 3

7 years ago
Comment on attachment 419143 [details] [diff] [review]
patch

this does fix the problem for me.
Attachment #419143 - Flags: superreview+
Attachment #419143 - Flags: review?(bienvenu)
Attachment #419143 - Flags: review+
Attachment #419143 - Flags: approval-thunderbird3.0.1?

Comment 4

7 years ago
We've had several reports of this...
Keywords: regression
I pushed this to trunk so we can get a little baking time before we want it on branch:

http://hg.mozilla.org/comm-central/rev/9659ba5295e6
Assignee: nobody → mvl
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Attachment #419143 - Flags: approval-thunderbird3.0.1? → approval-thunderbird3.0.1+
Patch checked into 3.0.1pre in time for 3.0.1:

http://hg.mozilla.org/releases/comm-1.9.1/rev/b6bf325fc693
status-thunderbird3.0: --- → .1-fixed

Updated

7 years ago
Keywords: fixed-seamonkey2.0.3
You need to log in before you can comment on or make changes to this bug.