536720 - "ASSERTION: not in child list", "ASSERTION: unexpected child list"

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: not in child list: 'found', file layout/base/nsLayoutUtils.cpp, line 268

###!!! ASSERTION: unexpected child list: 'Error', file layout/generic/nsBlockFrame.cpp, line 4968

Comment 1

[Jesse Ruderman]

Bug 540760 is probably related.

Comment 2

[Jesse Ruderman]

This is annoying because it can trigger many different assertions down the road.

Comment 3

[Jesse Ruderman]

How bad are these assertions?

Comment 4

[Timothy Nikkel (:tnikkel)]

I think Mats has dealt with some bugs with menupopups before.

Comment 5

[Mats Palmgren (inactive)]

A few more assertions when reloading the testcase:

ARNING: Unable to test style tree integrity -- no content node: file layout/base/nsCSSFrameConstructor.cpp, line 8070
###!!! ASSERTION: style context has old rule node: 'n == mRuleTree', file layout/style/nsStyleSet.cpp, line 170
###!!! ASSERTION: old rule tree still referenced: 'Not Reached', file layout/style/nsStyleSet.cpp, line 1127
WARNING: NS_ENSURE_TRUE(aContent->GetDocument()) failed: file layout/base/nsCSSFrameConstructor.cpp, line 9094
###!!! ASSERTION: Have parent context and shouldn't: 'Error', file layout/base/nsFrameManager.cpp, line 621
frame: MenuPopup(menupopup)(-1) (0x431cb40) style: 0x431c978 {}
Has parent context:  style: 0x438e5c8 {}
Should be null

Comment 6

[Mats Palmgren (inactive)]

It's a regression from http://hg.mozilla.org/mozilla-central/rev/912c5206ca3e
(the old code wasn't entirely correct either though)

Comment 7

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Looks like a typo.  Don't use popupList if that list is actually empty.

Comment 8

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Added crash test for bug 572003.

Comment 9

[fantasai]

Comment on attachment 451315 [details] [diff] [review]
Patch rev. 2

Didn't review the tests, but the patch makes sense.

Comment 10

[Mats Palmgren (inactive)]

http://hg.mozilla.org/mozilla-central/rev/a981e599a748

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: slightly better documentation

When reading this patch, I thought it would be nice to clarify what GetChildListNameFor is for.  (In particular, it's not useful for figuring out where to insert a frame.)

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/bff1302116cf