Closed
Bug 536720
Opened 15 years ago
Closed 14 years ago
"ASSERTION: not in child list", "ASSERTION: unexpected child list"
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
FIXED
mozilla2.0b1
Tracking | Status | |
---|---|---|
blocking2.0 | --- | final+ |
People
(Reporter: jruderman, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(3 files, 1 obsolete file)
544 bytes,
application/vnd.mozilla.xul+xml
|
Details | |
3.49 KB,
patch
|
fantasai.bugs
:
review+
|
Details | Diff | Splinter Review |
921 bytes,
patch
|
MatsPalmgren_bugz
:
review+
|
Details | Diff | Splinter Review |
###!!! ASSERTION: not in child list: 'found', file layout/base/nsLayoutUtils.cpp, line 268 ###!!! ASSERTION: unexpected child list: 'Error', file layout/generic/nsBlockFrame.cpp, line 4968
Reporter | ||
Comment 1•14 years ago
|
||
Bug 540760 is probably related.
Reporter | ||
Comment 2•14 years ago
|
||
This is annoying because it can trigger many different assertions down the road.
Reporter | ||
Comment 3•14 years ago
|
||
How bad are these assertions?
Reporter | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Comment 4•14 years ago
|
||
I think Mats has dealt with some bugs with menupopups before.
Assignee | ||
Comment 5•14 years ago
|
||
A few more assertions when reloading the testcase: ARNING: Unable to test style tree integrity -- no content node: file layout/base/nsCSSFrameConstructor.cpp, line 8070 ###!!! ASSERTION: style context has old rule node: 'n == mRuleTree', file layout/style/nsStyleSet.cpp, line 170 ###!!! ASSERTION: old rule tree still referenced: 'Not Reached', file layout/style/nsStyleSet.cpp, line 1127 WARNING: NS_ENSURE_TRUE(aContent->GetDocument()) failed: file layout/base/nsCSSFrameConstructor.cpp, line 9094 ###!!! ASSERTION: Have parent context and shouldn't: 'Error', file layout/base/nsFrameManager.cpp, line 621 frame: MenuPopup(menupopup)(-1) (0x431cb40) style: 0x431c978 {} Has parent context: style: 0x438e5c8 {} Should be null
Assignee | ||
Comment 6•14 years ago
|
||
It's a regression from http://hg.mozilla.org/mozilla-central/rev/912c5206ca3e (the old code wasn't entirely correct either though)
Assignee | ||
Comment 7•14 years ago
|
||
Looks like a typo. Don't use popupList if that list is actually empty.
Assignee: nobody → matspal
Attachment #451189 -
Flags: review?(fantasai.bugs)
Assignee | ||
Comment 8•14 years ago
|
||
Added crash test for bug 572003.
Attachment #451189 -
Attachment is obsolete: true
Attachment #451315 -
Flags: review?(fantasai.bugs)
Attachment #451189 -
Flags: review?(fantasai.bugs)
Comment on attachment 451315 [details] [diff] [review] Patch rev. 2 Didn't review the tests, but the patch makes sense.
Attachment #451315 -
Flags: review?(fantasai.bugs) → review+
Assignee | ||
Comment 10•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a981e599a748
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a6
When reading this patch, I thought it would be nice to clarify what GetChildListNameFor is for. (In particular, it's not useful for figuring out where to insert a frame.)
Attachment #454976 -
Flags: review?(matspal)
Assignee | ||
Updated•14 years ago
|
Attachment #454976 -
Flags: review?(matspal) → review+
blocking2.0: ? → final+
You need to log in
before you can comment on or make changes to this bug.
Description
•