536857 - It's possible to insert more than one line into a single line input field but only last line is shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Uwe Kaminski]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.6) Gecko/20091215 Ubuntu/9.10 (karmic) Firefox/3.5.6
Build Identifier: Mozilla 5.0 (X11; Linux armv7l; en-US; rv:1.9.2b6pre) Gecko/20091225 - Firefox/3.6b6pre Fennec/1.0b6pre

Only the last line is shown if you insert a multi line string into a single line input field.

Reproducible: Always

Steps to Reproduce:
1. Open a plain text editor and enter:
line1
line2
(line1 RETURN line2)
2. Mark the text in both lines and copy it 
3. Paste the copied text into a single line input field (like the search field on en.wikipedia.org) using fennec.
Actual Results:  
"line2" is shown. Move the cursor to the begin of the line and than press one more time the left arrow: "line1" is shown. Press right arrow: line2 is shown.

Expected Results:  
Like in firefox on desktop the line feed sign should be ignored and both lines should appear in the single line:
line1 line2

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This is controlled by the editor.singleLine.pasteNewlines pref. Valid values are:

66   const long eNewlinesPasteIntact                = 0;
67   const long eNewlinesPasteToFirst               = 1;
68   const long eNewlinesReplaceWithSpaces          = 2;
69   const long eNewlinesStrip                      = 3;
70   const long eNewlinesReplaceWithCommas          = 4;
71   const long eNewlinesStripSurroundingWhitespace = 5;

Firefox uses "1" for Linux (paste only the first non-empty line), and "2" otherwise (paste everything, replacing newlines with spaces). Not sure why Linux is different - I think we probably want "2" across the board?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

> I think we probably want "2" across the board?

Sounds good to me

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #1)
> Firefox uses "1" for Linux (paste only the first non-empty line), and "2"
> otherwise (paste everything, replacing newlines with spaces).

I was wrong about this, that was for the platform default. Firefox uses 2 across the board.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/ee82e1a8fe82

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2.2pre) Gecko/20100217 Namoroka/3.6.2pre Fennec/1.1a2pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a2pre) Gecko/20100217 Namoroka/3.7a2pre Fennec/1.1a2pre

We need a copy and paste testcase in our litmus BFTs. I'll use this bug as a placeholder for such a thing.

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Copy Paste support blocked by bug 585875

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=13652