536879 - Treehydra breaks callgraph

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ehren Metcalfe]

Attachment: backtrace

Running callgraph fails when encountering libtheora:

/home/ehren/new-tools/tools/callgraph/mozilla-central/mozilla/media/libtheora/lib/x86/mmxidct.c:342: internal compiler error: Segmentation fault

This was introduced with revision 0a5fc065b382 (Handle wide string literals in lazy_tree_string)

Comment 1

[Ehren Metcalfe]

btw,

(gdb) call TREE_TYPE (str)
$14 = (tree) 0x0

Comment 2

[(dormant account)]

Attachment: likely fix

Thanks for a backtrace. I'd appreciate a reduced testcase for this, but a confirmation will do too.

Comment 3

[Ehren Metcalfe]

Attachment: reduced testcase (delta produced)

I had to give up trying to put together a test case from first principles but here's how far I got with delta (see http://gcc.gnu.org/wiki/A_guide_to_testcase_reduction and http://delta.tigris.org/)

Comment 4

[Ehren Metcalfe]

Comment on attachment 419315 [details] [diff] [review]
likely fix

the patch also fixes the ICE

Comment 5

[Ehren Metcalfe]

Attachment: reduced testcase (delta produced)

just realized a few manual reductions could be carried out

Comment 6

[(dormant account)]

Interesting experience with automagic deltification. Glad to see that the manual approach won :)
i'm pretty sure having any sort of inline assembly will make unit tests fail on 
non-x86, gonna land this by itself.

Comment 7

[(dormant account)]

http://hg.mozilla.org/rewriting-and-analysis/dehydra/rev/54c8f525cde9