Last Comment Bug 536903 - [Mac] Need new css for clearListButton
: [Mac] Need new css for clearListButton
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Themes (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: seamonkey2.1a1
Assigned To: Stefan [:stefanh] (away until May 28)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-27 14:12 PST by Stefan [:stefanh] (away until May 28)
Modified: 2009-12-29 13:58 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
New css (2.81 KB, patch)
2009-12-27 14:15 PST, Stefan [:stefanh] (away until May 28)
mnyromyr: review+
neil: superreview+
Details | Diff | Review

Description Stefan [:stefanh] (away until May 28) 2009-12-27 14:12:58 PST
I forgot the button - same principle as the pageInfo css (all icons have been removed) in bug 525698.
Comment 1 Stefan [:stefanh] (away until May 28) 2009-12-27 14:15:03 PST
Created attachment 419260 [details] [diff] [review]
New css

I added Markus to the file since I rip most stuff from him.
Comment 2 neil@parkwaycc.co.uk 2009-12-29 11:59:14 PST
Comment on attachment 419260 [details] [diff] [review]
New css

>+  background: -moz-linear-gradient(top, #FFF, #ADADAD) repeat-x;
Three nits, two of which you got right later on:
1. repeat-x is unnecessary (makes no sense for a gradient)
2. should be background-image (background is a shortcut for multiple styles)
3. I'd prefer six-digit colour codes i.e. #FFFFFF throughout.

>+  background: #B5B5B5;
Nit: background-color

sr=me with these fixed.
Comment 3 neil@parkwaycc.co.uk 2009-12-29 13:23:44 PST
(In reply to comment #2)
>(From update of attachment 419260 [details] [diff] [review])
>>+  background: -moz-linear-gradient(top, #FFF, #ADADAD) repeat-x;
>Three nits, two of which you got right later on:
>1. repeat-x is unnecessary (makes no sense for a gradient)
>2. should be background-image (background is a shortcut for multiple styles)
>3. I'd prefer six-digit colour codes i.e. #FFFFFF throughout.
> 
>>+  background: #B5B5B5;
>Nit: background-color
OK, so the second is supposed to override the first, and just to be difficult, one uses a solid colour and one uses a gradient. In that case, how about:
background-color: #B5B5B5;
background-image: -moz-linear-gradient(top, #FFFFFF, #ADADAD);
...
background-image: none;
Comment 4 Stefan [:stefanh] (away until May 28) 2009-12-29 13:58:59 PST
Landed with suggested changes:
http://hg.mozilla.org/comm-central/rev/a61f577ca2e4

Then I discovered tha I missed one nit, so I landed another changeset:
http://hg.mozilla.org/comm-central/rev/2c8fc8ea5c2f

Note You need to log in before you can comment on or make changes to this bug.