537098 - |this.mInputElt is null| triggered by FireFTP extension.

Status: RESOLVED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[Philip Chee]

The XPFE autocomplete textbox binding falls over when bound to a FireFTP autocomplete textbox because it uses a feature in the toolkit autocomplete.xml not back-synced to XPFE.

Comment 1

[Philip Chee]

Attachment: Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem [Checkin: Comment 7]

STR:
1. Install FireFTP mod from:
<http://ftp.osuosl.org/pub/mozdev/xsidebar/mods/fireftp-1.0.7.xpi>
to SeaMonkey 2.1a1pre.

2. Navigate to the FireFTP install location and edit the chrome.manifest commenting out the following line:
#style   chrome://fireftp/content/fireftp.xul chrome://fireftp/content/fireftp.css application={92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}

3. Re-Start SeaMonkey. Go Tools->FireFTP.

4. Open the error console. Observe error:
Error: this.mInputElt is null
Source file: chrome://global/content/autocomplete.xml

Comment 2

[[e-mail]]

Comment on attachment 419419 [details] [diff] [review]
Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem
[Checkin: Comment 7]

>-        <children includes="image|deck|stack">
>+        <children includes="image|deck|stack|box">
Does FireFTP actually use a box child?

Comment 3

[Philip Chee]

> Does FireFTP actually use a box child?

<textbox id                      = "remotepath"
         value                   = "/"
         flex                    = "1"
         tooltiptext             = "&remotepath.tip;"
         onfocus                 = "onRemotePathFocus(event)"
         onblur                  = "onRemotePathBlur(event)"
         onkeypress              = "if (event.keyCode == 13) remoteDirTree.changeDir(this.value)"
         ontextentered           = "remoteDirTree.changeDir(this.value)"
         type                    = "autocomplete"
         tabscrolling            = "true"
         enablehistory           = "true"
         autocompletepopup       = "PopupAutoComplete"
         autocompletesearch      = "form-history"
         autocompletesearchparam = "remotepath">
  <box id="identity-box" align="center" popup="identity-popup">
    <deck id="page-proxy-deck">
      <image id="page-proxy-button"/>
      <image id="page-proxy-favicon" validate="never"
             onload="this.parentNode.selectedIndex = 1; event.stopPropagation();"
             onerror="this.removeAttribute('src'); this.parentNode.selectedIndex = 0;"/>
    </deck>
  </box>
</textbox>

Comment 4

[Philip Chee]

>          enablehistory           = "true"

Hmm. We don't have this either but fortunately disablehistory defaults to false

Comment 5

[[e-mail]]

Comment on attachment 419419 [details] [diff] [review]
Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem
[Checkin: Comment 7]

I checked hg blame and gavin tried and failed not to include the box. Oh well.

Comment 6

[[e-mail]]

(In reply to comment #4)
>>          enablehistory           = "true"
>Hmm. We don't have this either but fortunately disablehistory defaults to false
Incompatible implementation anyway.

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 419419 [details] [diff] [review]
Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem
[Checkin: Comment 7]


http://hg.mozilla.org/mozilla-central/rev/ca1c43fda0a9

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/83e708826865
|this.mInputElt is null| triggered by FireFTP extension; Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem.