Last Comment Bug 537098 - |this.mInputElt is null| triggered by FireFTP extension.
: |this.mInputElt is null| triggered by FireFTP extension.
Status: RESOLVED FIXED
parity-fx
:
Product: SeaMonkey
Classification: Client Software
Component: Autocomplete (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1a1
Assigned To: Philip Chee
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-12-29 07:25 PST by Philip Chee
Modified: 2010-01-04 22:16 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem [Checkin: Comment 7] (1.64 KB, patch)
2009-12-29 07:56 PST, Philip Chee
neil: review+
neil: superreview+
Details | Diff | Review

Description Philip Chee 2009-12-29 07:25:03 PST
The XPFE autocomplete textbox binding falls over when bound to a FireFTP autocomplete textbox because it uses a feature in the toolkit autocomplete.xml not back-synced to XPFE.
Comment 1 Philip Chee 2009-12-29 07:56:05 PST
Created attachment 419419 [details] [diff] [review]
Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem
[Checkin: Comment 7]

STR:
1. Install FireFTP mod from:
<http://ftp.osuosl.org/pub/mozdev/xsidebar/mods/fireftp-1.0.7.xpi>
to SeaMonkey 2.1a1pre.

2. Navigate to the FireFTP install location and edit the chrome.manifest commenting out the following line:
#style   chrome://fireftp/content/fireftp.xul chrome://fireftp/content/fireftp.css application={92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}

3. Re-Start SeaMonkey. Go Tools->FireFTP.

4. Open the error console. Observe error:
Error: this.mInputElt is null
Source file: chrome://global/content/autocomplete.xml
Comment 2 neil@parkwaycc.co.uk 2009-12-29 09:49:58 PST
Comment on attachment 419419 [details] [diff] [review]
Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem
[Checkin: Comment 7]

>-        <children includes="image|deck|stack">
>+        <children includes="image|deck|stack|box">
Does FireFTP actually use a box child?
Comment 3 Philip Chee 2009-12-29 11:14:50 PST
> Does FireFTP actually use a box child?

<textbox id                      = "remotepath"
         value                   = "/"
         flex                    = "1"
         tooltiptext             = "&remotepath.tip;"
         onfocus                 = "onRemotePathFocus(event)"
         onblur                  = "onRemotePathBlur(event)"
         onkeypress              = "if (event.keyCode == 13) remoteDirTree.changeDir(this.value)"
         ontextentered           = "remoteDirTree.changeDir(this.value)"
         type                    = "autocomplete"
         tabscrolling            = "true"
         enablehistory           = "true"
         autocompletepopup       = "PopupAutoComplete"
         autocompletesearch      = "form-history"
         autocompletesearchparam = "remotepath">
  <box id="identity-box" align="center" popup="identity-popup">
    <deck id="page-proxy-deck">
      <image id="page-proxy-button"/>
      <image id="page-proxy-favicon" validate="never"
             onload="this.parentNode.selectedIndex = 1; event.stopPropagation();"
             onerror="this.removeAttribute('src'); this.parentNode.selectedIndex = 0;"/>
    </deck>
  </box>
</textbox>
Comment 4 Philip Chee 2009-12-29 11:15:46 PST
>          enablehistory           = "true"

Hmm. We don't have this either but fortunately disablehistory defaults to false
Comment 5 neil@parkwaycc.co.uk 2010-01-03 07:47:14 PST
Comment on attachment 419419 [details] [diff] [review]
Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem
[Checkin: Comment 7]

I checked hg blame and gavin tried and failed not to include the box. Oh well.
Comment 6 neil@parkwaycc.co.uk 2010-01-03 07:47:49 PST
(In reply to comment #4)
>>          enablehistory           = "true"
>Hmm. We don't have this either but fortunately disablehistory defaults to false
Incompatible implementation anyway.
Comment 7 Serge Gautherie (:sgautherie) 2010-01-04 22:15:35 PST
Comment on attachment 419419 [details] [diff] [review]
Trunk Patch v1.0: Minimal backport from toolkit to fix the FireFTP problem
[Checkin: Comment 7]


http://hg.mozilla.org/mozilla-central/rev/ca1c43fda0a9

Note You need to log in before you can comment on or make changes to this bug.