537141 - "ASSERTION: Text node has a frame and NS_CREATE_FRAME_IF_NON_WHITESPACE" with XBL, MathML, SVG

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: XBL needed by the testcase

###!!! ASSERTION: Text node has a frame and NS_CREATE_FRAME_IF_NON_WHITESPACE: '!content->GetPrimaryFrame()', file /Users/jruderman/central/layout/base/nsCSSFrameConstructor.cpp, line 6080

I have a note that says this might be related to bug 396367, but I don't remember why I wrote that.

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

What happens here is that we end up creating an incorrect textframe (one with a wrong frametree parent) for a content node (for reasons much like those of bug 536623).  Then we go to try to construct the "right" textframe, discover it's not needed, and add the NS_CREATE_FRAME_IF_NON_WHITESPACE bit to a node that already has a textframe.  Then later we hit the assert this bug is about.

The proposed fix for bug 536623 should fix this.  We might want to add an assert at the callsite that adds NS_CREATE_FRAME_IF_NON_WHITESPACE that the content object doesn't have a frame already, though.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fixed by fix for bug 536623 (and the assert mentioned in comment 2 added).