/firefox/about/ page and rewrite rule are outdated

VERIFIED FIXED

Status

VERIFIED FIXED
9 years ago
6 years ago

People

(Reporter: tchung, Assigned: kourge)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Created attachment 419503 [details]
Unstarred bookmark screenshot

The About Us page (http://www.mozilla.com/en-US/firefox/about/) has been unstarred/unbookmarked, yet it still remains starred in the bookmarks list.

See screenshots

Repro;
1) Using N900, Mozilla/5.0 (X11; U; Linux armv71; en-US; rv:1.9.2b6pre)
Gecko/20091229 Fennec/1.0b6pre
2) goto About Us page (see URL)
3) swipe left, and Unstar / unbookmark the page
4) click the URL to pull up the bookmarks dashboard page
5) Verify the about US page is still starred.

Expected:
- The About Us page gets unstarred after unbookmarking it

Actual:
- About us page on the bookmarks dashboard is still starred
(Reporter)

Comment 1

9 years ago
Created attachment 419504 [details]
Starred bookmark screenshot
(Reporter)

Updated

9 years ago
OS: Mac OS X → All
Hardware: x86 → All
I bet that's because the bookmarks is on "http://www.mozilla.com/en-US/about/" but when going to the page I finished on http://www.mozilla.com/en-US/about/whatismozilla.html

In my case the star in the right sidebar is already unbookmarked
Component: General → Bookmarks
Is this still happening to you, Tony?
Looks like Vivien is right.  To delete this bookmark you can go to "All Bookmarks" and use the "Manage" button.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → INVALID
Uh, that's confusing to the user. We should move this bug over to webpages and try to find a solution there. This bug is not invalid as there is a break in the user experience of going to "About us". 

Alex, where would be an appropriate place to move this bug to?
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
A couple things,

1)  There is a website bug.  /{locale}/firefox/about/ is out-dated and should be removed, and the rewrite rule should be changed to point at /about/ instead of /about/whatismozilla.html IMO.  

Pascal, we could move localized /firefox/about/index.html pages to /about/index.html, since it looks like /about/index.html isn't localized yet.  Your call.

2)  The bookmark should point at /about/, not /firefox/about/ since that will always 301.  I've file bug 572056 for this.
Component: Bookmarks → www.mozilla.com
Product: Fennec → Websites
QA Contact: general → www-mozilla-com
Version: Trunk → other
Summary: About Us page is unbookmarked, but still starred → /firefox/about/ page and rewrite rule are outdated
Thanks for the help, Alex.
Wilson, could you?

Please remove /firefox/about/index.html

There are localized versions of /firefox/about/index.html.  You can move those to /{locale}/about/index.html

There is a rewrite that points /firefox/about/ to /about/whatismozilla.html.  Please change that to point to /about/.  Also, please make sure that rewrite uses [PT] (pass through) instead of redirecting, so that old bookmarks work correctly.
Assignee: nobody → kourge
(Assignee)

Comment 9

8 years ago
In addition to en-US/firefox/about/index.html, ko and pt-BR both have {locale}/firefox/about/index.html. Should those be removed as well?
ab-CD/firefox/about/ should be moved to ab-CD/about/, in the case of ko and pt-BR just delete /firefox/about, don't move them to ab-CD/about/
(Assignee)

Comment 11

8 years ago
Committed at r73217.
Keywords: qawanted
(Assignee)

Comment 12

8 years ago
Some files were accidentally deleted. Backing out and redoing.
(Assignee)

Comment 13

8 years ago
Okay, fixed at r73221.
1. http://www-trunk.stage.mozilla.com/en-US/firefox/about/index.html is removed, as per comment 8.
2. However, I thought http://www-trunk.stage.mozilla.com/en-US/firefox/about would redirect to http://www-trunk.stage.mozilla.com/en-US/about?

Does PT not trigger a 302?  When I ran http://www-trunk.stage.mozilla.com/en-US/firefox/about through Live HTTP Headers, I didn't see it redirect anywhere.  (Ditto for https://www-trunk.stage.mozilla.com/fr/firefox/about, etc.)
(Assignee)

Comment 15

8 years ago
No, per comment 8, http://www-trunk.stage.mozilla.com/en-US/firefox/about is rewritten with PT (Pass Through), so it serves identical content as http://www-trunk.stage.mozilla.com/en-US/about but does not redirect to it.
(In reply to comment #15)
> No, per comment 8, http://www-trunk.stage.mozilla.com/en-US/firefox/about is
> rewritten with PT (Pass Through), so it serves identical content as
> http://www-trunk.stage.mozilla.com/en-US/about but does not redirect to it.

OK, cool, thanks.  I'll remember that for future PT rewrites.  Removing qawanted keyword.
Keywords: qawanted
Wilson, can I push your changes to stage/prod?
(Assignee)

Comment 18

8 years ago
AFAICT this can be pushed to prod.
on production in r73889
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago8 years ago
Resolution: --- → FIXED
verified fixed on production 

http://www.mozilla.com/en-US/about


http://www.mozilla.com/es-CL/about
Status: RESOLVED → VERIFIED
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.