537288 - xptcinvoke for windows ce arm is incompatible with ARMv7 and newer

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

from bug 535894, comment 6:

>  - ldmia sp!, {r4-r6, sp, pc}
>
> From the ARM ARM: "Instructions with the base register in the list and !
> specified are only available in the ARM instruction set before ARMv7, and the
> use of such instructions is deprecated."

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 422258 [details] [diff] [review]
patch

makes sense to me (we're restoring from sp, so we should get the right value of sp at the end.. if we don't, we didn't restore from the right place), but let's get jacob to review as well.

Comment 3

[Jacob Bramley [:jbramley]]

Comment on attachment 422258 [details] [diff] [review]
patch

Yep, it looks right to me.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/0f2db07ea587

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/8f9bed819332