537344 - When a multi-byte letter is included in the name of the plugin, plugin name is broken.

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2b6pre) Gecko/20091230 Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091230 Minefield/3.7a1pre ID:20091230042231

When i installed "一太郎ビューア"("ititaro viewer")from http://www3.justsystem.co.jp/download/viewer/ichitaro/ ,an plugin is installed at the sametime.And the plugin name is including multi-byte letter .

Tools > Add-ons > Plugins
The page displays the name that I cannot read.



Reproducible: Always

Steps to Reproduce:
1.Install "一太郎ビューア"("ititaro viewer")from http://www3.justsystem.co.jp/download/viewer/ichitaro/
2.Start Minefield with new profile
3.Tools > Add-ons > Plugins

Actual Results:  
The page displays the name that I cannot read.

JS譁・嶌・具ｾ橸ｽｭ・ｰ・ｱ・鯉ｾ滂ｾ暦ｽｸ・橸ｽｲ・

Expected Results:  
The page should display the name that I can read.

JS文書ﾋﾞｭｰｱﾌﾟﾗｸﾞｲﾝ

Regression Window:

Works fine:
http://hg.mozilla.org/mozilla-central/rev/44c392db6672
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091214 Minefield/3.7a1pre ID:20091214045914

Broken:
http://hg.mozilla.org/mozilla-central/rev/96e8d529b2d3
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20091215 Minefield/3.7a1pre ID:20091215045531

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=44c392db6672&tochange=96e8d529b2d3

Comment 1

[Alice0775 White]

Attachment: Broken plugin name(screen shot)

Comment 2

[Alice0775 White]

Attachment: correct plugin name(screen shot)

Comment 3

[Alice0775 White]

Attachment: Applications also broken

Tools > Options... > Applications

The description of action is also broken.

Comment 4

[Alice0775 White]

And auto generated pluginreg.dat in profile folder is also broken.

The extract of the broken file:

扣S譁・嶌・具ｾ橸ｽｭ・ｰ・ｱ・鯉ｾ滂ｾ暦ｽｸ・橸ｽｲ・|$
JS譁・嶌・具ｾ橸ｽｭ・ｰ・ｱ・鯉ｾ滂ｾ暦ｽｸ・橸ｽｲ・|$
8
0|application/x-js-hana|晁干蟄仙峙髱｢繝輔ぃ繧､繝ｫ|jhd,jht,jbh,juh,jah,jth,jsh,jhdc,jhtc|$
1|application/x-js-sns|荳牙屁驛弱Ρ繝ｼ繧ｯ繧ｷ繝ｼ繝医ヵ繧｡繧､繝ｫ|jsd,jst,jac,jtc,jsr|$
2|application/jxw|荳螟ｪ驛趣ｼ匁枚譖ｸ繝輔ぃ繧､繝ｫ|jbw,jxw,jsw,jaw,jtw,juw|$
3|application/x-js-jxw|荳螟ｪ驛趣ｼ匁枚譖ｸ繝輔ぃ繧､繝ｫ|jbw,jxw,jsw,jaw,jtw,juw|$
4|application/x-js-taro|荳螟ｪ驛取枚譖ｸ繝輔ぃ繧､繝ｫ|jtd,jtt,jfw,jxw,jsw,jaw,jtw,jbw,juw,jvw,jtdc,jttc|$
5|application/x-js-jtdx-taro|荳螟ｪ驛珊ML繝・Φ繝励Ξ繝ｼ繝域枚譖ｸ繝輔ぃ繧､繝ｫ|jtdx|$
6|application/x-js-jtsd-taro|荳螟ｪ驛朱崕蟄千ｽｲ蜷阪そ繧ｭ繝･繝ｪ繝・ぅ譁・嶌繝輔ぃ繧､繝ｫ|jtsd|$
7|application/x-ole2|荳螟ｪ驛取枚譖ｸ繝輔ぃ繧､繝ｫ|jtd|$


The extract of the correct file:

JS文書ﾋﾞｭｰｱﾌﾟﾗｸﾞｲﾝ|$
JS文書ﾋﾞｭｰｱﾌﾟﾗｸﾞｲﾝ|$
8
0|application/x-js-hana|花子図面ファイル|jhd,jht,jbh,juh,jah,jth,jsh,jhdc,jhtc|$
1|application/x-js-sns|三四郎ワークシートファイル|jsd,jst,jac,jtc,jsr|$
2|application/jxw|一太郎６文書ファイル|jbw,jxw,jsw,jaw,jtw,juw|$
3|application/x-js-jxw|一太郎６文書ファイル|jbw,jxw,jsw,jaw,jtw,juw|$
4|application/x-js-taro|一太郎文書ファイル|jtd,jtt,jfw,jxw,jsw,jaw,jtw,jbw,juw,jvw,jtdc,jttc|$
5|application/x-js-jtdx-taro|一太郎XMLテンプレート文書ファイル|jtdx|$
6|application/x-js-jtsd-taro|一太郎電子署名セキュリティ文書ファイル|jtsd|$
7|application/x-ole2|一太郎文書ファイル|jtd|$

Comment 5

[Masahiro YAMADA]

Seems to be reading UTF-8 text as Shift_JIS.
And this bug may be realted to bug 420280.

Comment 6

[Masahiro YAMADA]

about:plugins is also broken.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20100104
Minefield/3.7a1pre

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The regression range has very many check-ins...

Comment 8

[Masatoshi Kimura [:emk]]

nsPluginInfo will have UTF-8 strings on Windows if UNICODE is defined.
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/src/nsPluginsDirWin.cpp#59
And UNICODE will be defined when MOZ_IPC is enabled.
http://mxr.mozilla.org/mozilla-central/source/modules/plugin/base/src/Makefile.in#114
http://mxr.mozilla.org/mozilla-central/source/ipc/chromium/chromium-config.mk#78
Therefore EnsureMembersAreUTF8 will convert strings that are already in UTF-8.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you, Kimura-san, I'll post a patch.

Comment 10

[[e-mail]]

Hmm, I seem to remember trying to fix this before, in attachment 308616 [details] [diff] [review]
(bug 422079), but it was deemed too risky then.

Comment 11

[Benjamin Smedberg]

I believe my patch in bug 545080 fixes this.

Comment 12

[[e-mail]]

(In reply to comment #11)
> I believe my patch in bug 545080 fixes this.
It's tricky to tell given the bitrot, but yes, it appears that it subsumes attachment 308616 [details] [diff] [review].

Comment 13

[Benjamin Smedberg]

fixed by bug 545080, and on lorentz heading to 1.9.2.3

Comment 14

[Masahiro YAMADA]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a4pre) Gecko/20100324 Minefield/3.7a4pre
When using new profile , problem is not reproduced.
BUT, when using profile that contains already-broken pluginreg.dat (see comment #4), problem is still reproduced.

Comment 15

[Masahiro YAMADA]

To make not-reproduce completely, recovery of already-broken pluginreg.dat is needed (And one of most simple way is "create new profile").

This bug is ONLY-trunk bug. I think , "creating new profile" is enough for  followup for users who has already-broken pluginreg.dat.
But it may be better to write about this issue on releasenote of next release of "Mozilla Developer Preview of Gecko 1.9.3".

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Blanket approval for Lorentz merge to mozilla-1.9.2
a=beltzner for 1.9.2.4 - please make sure to mark status1.9.2:.4-fixed

Comment 17

[Benjamin Smedberg]

Merged into 1.9.2 at http://hg.mozilla.org/releases/mozilla-1.9.2/rev/84ba4d805430