537417 - topcrash [@ CollectNewLoadedModules]

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There have been crashes on 3.7a1pre (mozilla-central) nightlies at CollectNewLoadedModules.  They started showing up on Dec. 20, and the histogram by build looks like:

2009-12-20  5
2009-12-21 32
2009-12-22 36
2009-12-23 16
2009-12-24 29
2009-12-25  -
2009-12-26 14
2009-12-27 22
2009-12-28  -
2009-12-29  7
2009-12-30 16

http://crash-stats.mozilla.com/report/list?range_value=4&range_unit=weeks&signature=CollectNewLoadedModules&version=Firefox%3A3.7a1pre

I think this is probably a regression from the skidmark patch in bug 524944.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Probably a shutdown crash; I think nsAppShell::Run just needs to set sLoadedModules back to null before it exits.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Presumably fixed by the patch in bug 545195.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yeah