53750 - Typing v acts like Ctrl-V (i.e. paste)

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Viswanath Ramachandran]

Install and start commercial build 2000092208.
Copy something into clipboard in another windows app.
Now in any entry field of Seamonkey such as the browsers
location field type the small alphabet v.
The result is that it fills v + also the clipboard i.e.
as if you also typed Ctrl-v.
Unacceptable behaviour at this stage. This has regressed
and has to be fixed before we ship b3.
thanks, Vishy

Comment 1

[Viswanath Ramachandran]

nominating blocker, dogfood, nsbeta3.
maybe its not a blocker (please judge) but it has
to be dogofood at least.

what is worrisome is that this seems like some
core low level infrastructure and a regression in
that is costly.

thanks, Vishy
thanks, Vishy

Comment 2

[don]

I don't think this thing is a smoketest blocker but I sure want it fixed in beta
3.  Can PDT please "++" this?

Sairuh, can you remove this from smoketest blocker status?

Paul, who's bug is this really?

Comment 3

[Paul Chen]

yikes, also happens on my mac commercial build from this morning

Comment 4

[Paul Chen]

also happens under my mozilla build, marking as all because it looks like xp
problem to me

Comment 5

[Viswanath Ramachandran]

Hyatt, does your XBL keybindings stuff have anything to do with this?

thanks, Vishy

Comment 6

[Viswanath Ramachandran]

don i would push hard for tree to be held for this (i.e. blocker).
the product is unusable basically. I have to type V for everything
instad of the small letter.

Comment 7

[John Unruh]

*** Bug 53738 has been marked as a duplicate of this bug. ***

Comment 8

[don]

This looks like it may be due to Hyatt's changes last night.  Re-assigning to
virtual Hyatt for now ...

Comment 9

[Asa Dotzler [:asa]]

I understand your wanting to hold the tree closed for this. It is ugly, but not
really a smoketest and not really a blocker.  You can use a "V" also the lower
case "v " is typed along with the pasting and if your clipboard is empty or has
a space in it then typing isn't really that horrible, not so much that the
product becomes unuseable or untestable in my opinion.  This also does not
appear to be a problem in the mail message compose  or composer content area.

Comment 10

[saari (gone)]

I'm on my way into the office to look at this...

Comment 11

[scottputterman]

I'm pretty sure this is the fix. At least it makes it work for me:

Index: resources/content/htmlBindings.xml
===================================================================
RCS file: /cvsroot/mozilla/xpfe/global/resources/content/htmlBindings.xml,v
retrieving revision 1.7
diff -c -r1.7 htmlBindings.xml
*** htmlBindings.xml	2000/09/22 05:22:23	1.7
--- htmlBindings.xml	2000/09/22 18:46:13
***************
*** 34,40 ****
  
        <handler event="keypress" key="x" command="cmd_cut" modifiers="accel"/>
        <handler event="keypress" key="c" command="cmd_copy" modifiers="accel"/>
!       <handler event="keypress" key="v" command="cmd_paste" 
moodifiers="accel"/>
        <handler event="keypress" key="z" command="cmd_undo" modifiers="accel"/>
        <handler event="keypress" key="y" command="cmd_redo" modifiers="accel"/>
      </handlers>
--- 34,40 ----
  
        <handler event="keypress" key="x" command="cmd_cut" modifiers="accel"/>
        <handler event="keypress" key="c" command="cmd_copy" modifiers="accel"/>
!       <handler event="keypress" key="v" command="cmd_paste" 
modifiers="accel"/>
        <handler event="keypress" key="z" command="cmd_undo" modifiers="accel"/>
        <handler event="keypress" key="y" command="cmd_redo" modifiers="accel"/>
      </handlers>

Comment 12

[Dan Rosen]

Attachment: patch for typo.

Comment 13

[Dan Rosen]

putterman: yep. that's the one. mmmm, moodifiers :)

Comment 14

[Viswanath Ramachandran]

yes that really made the app moody :-)

Comment 15

[Henri Sivonen (:hsivonen)]

*** Bug 53718 has been marked as a duplicate of this bug. ***

Comment 16

[Dan Rosen]

fix checked in.

Comment 17

[Gagan]

*** Bug 53785 has been marked as a duplicate of this bug. ***

Comment 18

[sairuh (rarely reading bugmail)]

yech. will vrfy once i get a new build.

Comment 19

[Luis Villa]

*** Bug 54010 has been marked as a duplicate of this bug. ***

Comment 20

[sairuh (rarely reading bugmail)]

vrfy fixed using 2000.09.29.xx-n6 [opt comm branch bits] on linux, mac and
winnt.

Comment 21

[Asa Dotzler [:asa]]

Verified Fixed with win32 mozilla trunk build 100204, linux mozilla trunk build
100208 and mac mozilla trunk build 100208.  Setting bug status to Verified and
removing the vtrunk keyword.