Closed Bug 537513 Opened 15 years ago Closed 15 years ago

Apply SUMO theme to tiki-trunk

Categories

(support.mozilla.org :: General, defect, P1)

Product:
support.mozilla.org
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: djst, Assigned: jsocol)

References

(
URL
)

Details

Attachments

(1 file)

SUMO theme on my local tiki trunk, for KB article "Clear Recent History"
217.79 KB, image/png
Details
http://tiki-trunk.mozilla.com/ should use the same SUMO theme (with the same copyrighted graphics) as we use on the production server. It probably needs to be upgraded to work in Tiki 5.x. Marc: I think an attempt to upgrade and upstream our theme was done before. Can we use that work to get things started more quickly here?
Assignee: nobody → james
Severity: normal → critical
Priority: -- → P1
Hi! I spoke to Gary. So you can rename theme or use as is. I suggest applying to trunk http://tiki-trunk.mozilla.com/ which will bring the discussion about how do we have the code there be up to date from multiple source.
The demo and the code seem very incomplete. We use 12 different themes (often symlinked together, but still) and override dozens of tiki templates in those themes. There are only 4 templates in your third SF link, which only seem to cover the old home page (mozms) and KB articles. I'll see if we can't set this up to pull down our themes, probably out of a branch, then we can actually start filing bugs to fix the issues we encounter.
Perhaps it's incomplete. I don't know :-) Gary makes a point of trying to avoid overriding templates because it makes management more difficult down the line. Also, it seems to me that forked templates from a 2+ year old code base will most certainly cause havoc. I feel it's better to re-introduce needed changes to the new code base. But let's see :-) I suggest to get both in and we can easily try both and compare. Can you setup svn external or something like that so Gary can make fixes to SVN? Thanks!
Blocks: 538387
SVN external probably won't work in this situation, but I'll work with IT to get something set up. What does Gary suggest instead of overriding templates? That seemed to be the entire basis for the theme system in our version of TikiWiki.
> What does Gary suggest instead of overriding templates? That seemed to be the > entire basis for the theme system in our version of TikiWiki. This is what I have seen from Gary, Patrick, luci and others 1- Every version, we try to be able to do more stuff via CSS (tableless layouts, etc) 2- Every version, we have more & more things which are configurable in Admin > Look & Feel > General layout (tiki-admin.php?page=look) and stored in the DB. Headers and Footers notably. 3- Put a bit of logic (depending on group, category, etc.) in the above section or in a .tpl http://themes.tikiwiki.org/Template+Tricks 4- We now have theme options to help making minor variations on a theme (instead of forking the whole thing) 5- When it's just a small change, just change the main templates/tiki-abc.tpl so it takes advantage of SVN merges 6- Only when there is a major change, to fork the template and have in templates/styles/xyz/tiki-abc.tpl With all this, I have seen very impressive site look changes by forking a handful of templates.
Here's a screenshot of what I currently have locally. To get this: * copy over trunk/webroot/styles/moz* * copy over trunk/webroot/templates/styles/moz* Quick fixes I did: * removed our header.tpl theme check for $feature_page_title (now empty variable), to make the title show up * $feature_left_column is also empty, updated our layout a bit to remove this * added an "@import url('mozcommon.css');" at the top of mozkb.css, to load both mozkb and mozcommon Among the broken things, what I noted so far are: * breadcrumbs do not include KB category or page title (maybe there's a pref for this? I couldn't find it) * broken plugins: {IMG}, {PATH}, {MENU}, and of course {SHOWFOR} * disabled plugins: {ALINK}, {TAG} * missing translate/monitor/source links from the "Actions" box The above is only for KB articles. I took a look at a few more pages: * although not obvious, much of the javascript functionality from the old templates is broken, and also some new javascript. Most notably, tabs in the admin area don't work anymore. * the editpage template doesn't look usable * tiki-admin.php?page=textarea runs out of memory (though it loads on tiki-trunk.mo) Looking around, I imagine we will have to update most of our old admin templates, especially since some options weren't upstreamed or are no longer available in Tiki 5. We may be able to start from the tiki templates and modify them. Thoughts? Next steps?
Attachment #422637 - Attachment description: SUMO theme on my local tiki trunk, for KB article "Clearing Private Data" → SUMO theme on my local tiki trunk, for KB article "Clear Recent History"
David: Are we ok to add SUMO theme as a native Tiki theme in Tiki trunk, minus the logo? Thanks!
Very pleased to see progress on this! (In reply to comment #8) > Created an attachment (id=422637) [details] > SUMO theme on my local tiki trunk, for KB article "Clearing Private Data" > > Here's a screenshot of what I currently have locally. To get this: > * copy over trunk/webroot/styles/moz* > * copy over trunk/webroot/templates/styles/moz* > Each .tpl has a pretty good chance of being busted (because of 2-year delta). Changes should be re-introduced compared to the most recent .tpl Also, you should look at: http://tikiwiki.svn.sourceforge.net/viewvc/tikiwiki/branches/experimental/sumo/ > > Among the broken things, what I noted so far are: > * breadcrumbs do not include KB category or page title (maybe there's a pref > for this? I couldn't find it) Is this the Tiki breadcrumbs feature or something else? > * broken plugins: {IMG}, {PATH}, {MENU}, and of course {SHOWFOR} > * disabled plugins: {ALINK}, {TAG} IMG: perhaps a collision with rewrite Rules? This should work PATH: need to create as a PluginAlias MENU: need to create as a PluginAlias ALINK: just activate it TAG: just activate it SHOWFOR: I think will be maintained locally, and upstreamed later. No rush to upstream but no reason not to make generic and upstream. We should address this: https://bugzilla.mozilla.org/show_bug.cgi?id=539151 And thus, everyone could "replay" these steps in one click. > * missing translate/monitor/source links from the "Actions" box > Not sure what/where this is. > The above is only for KB articles. > > I took a look at a few more pages: > * although not obvious, much of the javascript functionality from the old > templates is broken, and also some new javascript. Most notably, tabs in the > admin area don't work anymore. hmmm, If you switch to non-SUMO theme, does it work? If tabs where broken in Tiki trunk, I would have noticed. > * the editpage template doesn't look usable As with all .tpls, needs/changes need to be re-introduced against latest. > * tiki-admin.php?page=textarea runs out of memory (though it loads on > tiki-trunk.mo) > > Looking around, I imagine we will have to update most of our old admin > templates, especially since some options weren't upstreamed or are no longer > available in Tiki 5. We may be able to start from the tiki templates and modify > them. > Perhaps for easy maintenance, all SUMO-only admin things should be in a specific SUMO admin panel? Sometimes, we refactor stuff there. > Thoughts? Next steps? Keep it up! My ideas outlined above :-) Where will the SUMO-specific changes be documented? Just SVN? Thanks!
Marc, short answer from legal about adding the SUMO theme: No. Long answer: the look and feel of any Mozilla web property is copyright, not Creative Commons. "The trademarks and logos of the Mozilla Foundation and any third party and the look and feel of this web site (to the extent the look and feel elements are works of authorship, such as the graphic design, artwork, and artistic illustrations) are not included in the work that is licensed under the Creative Commons terms." http://www.mozilla.com/en-US/about/legal.html#site Contact legal@mozilla.com if you have questions about what you can and cannot use but redistributing the existing theme as is would not be OK.
(In reply to comment #10) > Each .tpl has a pretty good chance of being busted (because of 2-year delta). > Changes should be re-introduced compared to the most recent .tpl > > Also, you should look at: > http://tikiwiki.svn.sourceforge.net/viewvc/tikiwiki/branches/experimental/sumo/ Could you be more specific about what I should look for? Have templates been updated there? > Is this the Tiki breadcrumbs feature or something else? It's probably related to our templates and not Tiki. Anyway, I'm not sure where to customize breadcrumbs yet, but I will look into it more. > IMG: perhaps a collision with rewrite Rules? This should work I'm not sure how rewrite rules could have anything to do with this? The wiki syntax is, e.g. {img src="img/wiki_up/dc83bef63b83bac0c4f29a23fe07e0f0-1259119863-720-1.png" } Perhaps the lowercase may be the cause? Has the syntax changed? > PATH: need to create as a PluginAlias > MENU: need to create as a PluginAlias Need to investigate this. I will post info in bug 539148 once I have something. > ALINK: just activate it > TAG: just activate it Could you help me find where to activate these? > We should address this: > https://bugzilla.mozilla.org/show_bug.cgi?id=539151 I imagine we would create a profile once we have things working. Is that not how profiles work? Perhaps you can post in that bug what steps we should be taking. I'm not familiar enough with the changes yet. > hmmm, If you switch to non-SUMO theme, does it work? If tabs where broken in > Tiki trunk, I would have noticed. Yes it works, in the strasa theme, for example. > As with all .tpls, needs/changes need to be re-introduced against latest. I totally agree. My intent was to provide a quick overview of what things look like, to help estimate how much work needs to be done, among other things. A particular concern here is that thoroughly examining and modifying ALL or most of our templates isn't really a suitable solution - we might as well rewrite them. Tabs functionality (above) deals with this concern, too. It is possible that we can use the Tiki templates entirely for the admin side of SUMO. Related: it would be great if you could have a look at bug 538387 comment 8. > Perhaps for easy maintenance, all SUMO-only admin things should be in a > specific SUMO admin panel? Sometimes, we refactor stuff there. I'm ok with all SUMO-specific features to have their own admin panel. Would that be ok to upstream, though? Or it could be part of a profile? > Where will the SUMO-specific changes be documented? Just SVN? Probably a wiki page. We will definitely have patches in bugzilla for anything we change, so that would help for upstreaming (if you wish to). James or Laura can expand on this.
(In reply to comment #12) > I'm not sure how rewrite rules could have anything to do with this? The wiki > syntax is, e.g. {img > src="img/wiki_up/dc83bef63b83bac0c4f29a23fe07e0f0-1259119863-720-1.png" } > Perhaps the lowercase may be the cause? Has the syntax changed? Nevermind, {img} works, I was confused by the appended icon: <a class="editplugin" href="javascript:void(1)" id="plugin-edit-img1"><img border="0" width="16" height="16" class="icon" title="Edit Plugin:img" alt="Edit Plugin:img" src="pics/icons/wiki_plugin_edit.png"></a> Here's another example where the javascript does not work yet. Clicking on this does not take any action. I'm sure this can be fixed in our templates somewhere, I just need to dig for it.
(In reply to comment #12) > (In reply to comment #10) > Could you be more specific about what I should look for? Have templates been > updated there? > Yes, see comment #1 above. Gary already ported SUMO to Tiki4 (mostly by reverse engineering from final output), which is very similar to Tiki5, theme-wise. > > Is this the Tiki breadcrumbs feature or something else? > It's probably related to our templates and not Tiki. Anyway, I'm not sure where > to customize breadcrumbs yet, but I will look into it more. > OK, Tiki breadcrumbs are in need of a revamp. If it looks like something that could/should be upstreamed... > > > ALINK: just activate it > > TAG: just activate it > Could you help me find where to activate these? > For all settings/configuration/preference: 1- tiki-admin.php 2- Use the search box at the top > > We should address this: > > https://bugzilla.mozilla.org/show_bug.cgi?id=539151 > I imagine we would create a profile once we have things working. Is that not > how profiles work? Perhaps you can post in that bug what steps we should be > taking. I'm not familiar enough with the changes yet. > Done. > > hmmm, If you switch to non-SUMO theme, does it work? If tabs where broken in > > Tiki trunk, I would have noticed. > Yes it works, in the strasa theme, for example. > OK, so let's use standard Tiki tabs instead, and improve them if necessary. > > As with all .tpls, needs/changes need to be re-introduced against latest. > I totally agree. My intent was to provide a quick overview of what things look > like, to help estimate how much work needs to be done, among other things. A > particular concern here is that thoroughly examining and modifying ALL or most > of our templates isn't really a suitable solution - we might as well rewrite > them. Tabs functionality (above) deals with this concern, too. > And to know if we still want the changes, we need to test production against/compared to http://tiki-trunk.mozilla.com/ I think reverse engineering from the current live site will be, most of the time, less work than trying to decipher the templates. > It is possible that we can use the Tiki templates entirely for the admin side > of SUMO. Related: it would be great if you could have a look at bug 538387 > comment 8. > I am not sure I understand this. Can you elaborate? > > Perhaps for easy maintenance, all SUMO-only admin things should be in a > > specific SUMO admin panel? Sometimes, we refactor stuff there. > I'm ok with all SUMO-specific features to have their own admin panel. Would > that be ok to upstream, though? Or it could be part of a profile? > As for SUMO-specific admin panel / pref management Plan A: get LPH to create a dynamic admin panel from all SUMO-only settings. This would be upstreamed. And any project could maintain custom prefs this way. Plan B: maintain a hard-coded tiki-admin.php?page=sumo This would not be upstreamed In both cases, profiles could be applied. Profiles are "just" a faster/easier way to change settings and/or create/alter data. > > Where will the SUMO-specific changes be documented? Just SVN? > Probably a wiki page. We will definitely have patches in bugzilla for anything > we change, so that would help for upstreaming (if you wish to). James or Laura > can expand on this. OK, whatever the method is fine, as long as we pick one and are disciplined. 6 months after this upgrade, we'll have another to do :-) Keep up the great work! I am very happy we are getting into these nitty gritty details. It means we are getting closer & closer to success.
> > As for SUMO-specific admin panel / pref management > > Plan A: > get LPH to create a dynamic admin panel from all SUMO-only settings. This would > be upstreamed. And any project could maintain custom prefs this way. > > Plan B: > maintain a hard-coded tiki-admin.php?page=sumo > This would not be upstreamed > > In both cases, profiles could be applied. Profiles are "just" a faster/easier > way to change settings and/or create/alter data. > Spin off to: SUMO-specific admin panel / pref management https://bugzilla.mozilla.org/show_bug.cgi?id=541106
(In reply to comment #14) > For all settings/configuration/preference: > 1- tiki-admin.php > 2- Use the search box at the top Couldn't find either of them, searching for "menu" or "alink" both lower and upper case. > > It is possible that we can use the Tiki templates entirely for the admin side > > of SUMO. Related: it would be great if you could have a look at bug 538387 > > comment 8. > I am not sure I understand this. Can you elaborate? Can we have one set of themes for the admin pages, and another set of themes for the rest of the pages? Conceptually, this is similar to Wordpress' back-end administration area as opposed to the blog theme.
(In reply to comment #16) > (In reply to comment #14) > > For all settings/configuration/preference: > > 1- tiki-admin.php > > 2- Use the search box at the top > Couldn't find either of them, searching for "menu" or "alink" both lower and > upper case. > PluginMenu doesn't exist, as it's a SUMO creation. Need to make via PluginAlias try a-link or anchor. This is a new feature, a few tweaks needed :-) > > > > It is possible that we can use the Tiki templates entirely for the admin side > > > of SUMO. Related: it would be great if you could have a look at bug 538387 > > > comment 8. > > I am not sure I understand this. Can you elaborate? > Can we have one set of themes for the admin pages, and another set of themes > for the rest of the pages? Conceptually, this is similar to Wordpress' back-end > administration area as opposed to the blog theme. Yes, you can override themes per object, category, user, group, etc. http://doc.tikiwiki.org/Theme+Control There is not really a section for admin though. It will just use the default theme of the site. Do you want an admin section added?
I understand that by applying SUMO *.tpl, there is an attempt to evaluate how much time it will take to re-introduce. Perhaps it's because I am unaware of everything that has been done in the .tpl (is there business logic there?), but I feel the order is: 1- Make Tiki work in trunk for all the features SUMO is using, regardless of the look & feel. Check features & workflow. There are 70+ items in tiki_test. These tests will lead to bug fixes and feature tweaks. Making trunk-tiki look like like current SUMO is lower priority than the features. 2- Once all features are settled, re-integrate cosmetic look & feel things against the most recent .tpl & css, mostly by reverse-engineering (taking current SUMO and doing only what's needed)
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
For the record, alink is fixed. > Couldn't find either of them, searching for "menu" or "alink" both lower and > upper case. >
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: