Closed
Bug 537525
Opened 16 years ago
Closed 15 years ago
Profile importer should not treat error as fatal when reading from Windows registry
Categories
(SeaMonkey :: Startup & Profiles, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1a1
People
(Reporter: mcsmurf, Assigned: mcsmurf)
Details
(Keywords: fixed-seamonkey2.0.3)
Attachments
(1 file, 1 obsolete file)
6.50 KB,
patch
|
standard8
:
review+
kairo
:
approval-seamonkey2.0.3+
|
Details | Diff | Splinter Review |
Currently the SeaMonkey profile importer for SeaMonkey 1.x and Thunderbird profile just aborts migration when it cannot read the registry key HKLM\\SOFTWARE\\Classes\\HTTP\\shell\\open\\command, see http://hg.mozilla.org/comm-central/annotate/20c2d9e8e9b4/suite/profile/migration/src/nsProfileMigrator.cpp#l180. I spoke to some user where migration failed due to that. I'm not yet sure why this registry key was missing (he had Firefox set as default browser, but is also using SeaMonkey 1.x), but I think this one should not be fatal for profile migration. After all we could jump in this case to http://hg.mozilla.org/comm-central/annotate/20c2d9e8e9b4/suite/profile/migration/src/nsProfileMigrator.cpp#l266:
// We can't get the default migrator (either wrong OS or we don't have a
// migrator for the default browser), so fall back to finding a valid
// profile to migrator manually - first try what we've been given.
Assignee | ||
Updated•16 years ago
|
Summary: Profile importer should not treat error when reading from Windows registry as fatal → Profile importer should not treat error as fatal when reading from Windows registry
Updated•16 years ago
|
Component: General → Startup & Profiles
QA Contact: general → profile-manager
Assignee | ||
Comment 1•16 years ago
|
||
I could not really work out how I can get hg qdiff to ignore all whitespace changes (I tested with -w, did not work), basically I changed FAILED->SUCCEEEDED and the else case could be to continue in the block below.
Assignee: nobody → bugzilla
Attachment #419795 -
Flags: review?(bugzilla)
Assignee | ||
Comment 2•16 years ago
|
||
Actually ignore the whitespace changes comment, it did ignore the whitespace changes :)
Assignee | ||
Updated•16 years ago
|
Flags: blocking-seamonkey2.0.3?
![]() |
||
Updated•16 years ago
|
Flags: blocking-seamonkey2.0.3? → blocking-seamonkey2.0.3+
Updated•15 years ago
|
Attachment #419795 -
Flags: review?(bugzilla) → review-
Comment 3•15 years ago
|
||
Comment on attachment 419795 [details] [diff] [review]
Patch
The general idea looks fine, but can you attach a normal patch so that I can assess the whitespace changes, as what's indicated in this patch is just weird.
Assignee | ||
Comment 4•15 years ago
|
||
Attachment #425537 -
Flags: review?(bugzilla)
Comment 5•15 years ago
|
||
Comment on attachment 425537 [details] [diff] [review]
Patch with whitespace changes
That's better, using my own version of diffw its much clearer :-)
r=Standard8
Attachment #425537 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 6•15 years ago
|
||
Comment on attachment 425537 [details] [diff] [review]
Patch with whitespace changes
Risk: Will change how SeaMonkey 1.1.18 profile importer will behave when a certain registry key is not found. Might help people who have problems with profile import on Windows.
Attachment #425537 -
Flags: approval-seamonkey2.0.3?
![]() |
||
Updated•15 years ago
|
Attachment #425537 -
Flags: approval-seamonkey2.0.3? → approval-seamonkey2.0.3+
![]() |
||
Comment 7•15 years ago
|
||
Frank, please check in on 1.9.1 ASAP so we can start 2.0.3 builds. Thanks.
Assignee | ||
Comment 8•15 years ago
|
||
Pushed to 1.9.1: http://hg.mozilla.org/releases/comm-1.9.1/rev/39e6436e83fc
Will push to comm-central when the tree is green again
Keywords: fixed-seamonkey2.0.3
![]() |
||
Comment 9•15 years ago
|
||
Ping Frank, time to push to comm-central?
Assignee | ||
Comment 10•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Attachment #419795 -
Attachment is obsolete: true
Updated•15 years ago
|
Target Milestone: --- → seamonkey2.1a1
You need to log in
before you can comment on or make changes to this bug.
Description
•