537743 - rename AvmCore::readU30 -> readU32, to reflect reality

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Edwin Smith]

Other callers of AvmCore::readU30() perform range checks; this function actually reads and returns 32 bit values, so its name should reflect that.

Comment 1

[Edwin Smith]

Attachment: rename AvmCore::readU30 -> readU32

Also in this patch:

rename Debugger::readU30 -> readU32, since it's just a wrapper around AvmCore's function.

Added PoolObject::hasMetadataName(), to encapsulate ABC parsing in the VM.  (host code using metadata should not parse it directly!)

Comment 2

[Steven Johnson]

Comment on attachment 419935 [details] [diff] [review]
rename AvmCore::readU30 -> readU32

-- where's an example of usage of hasMetadataName?

-- this code in hasMetadataName must be changed:

int metadata_count = AvmCore::readU32(meta_pos); // naked int -> uint32_t, please

-- we should probably rename skipU30() to skipU32() at the same time, since it's semantically paired with readU30()

Comment 3

[Edwin Smith]

Attachment: (v2) rename AvmCore::readU30 -> readU32

* s/int/uint32_t/ in PoolObject::hasMetadataName()
* Rename AvmCore::skipU30 -> skipU32 for parity with readU32()

Comment 4

[Edwin Smith]

pushed http://hg.mozilla.org/tamarin-redux/rev/eee833c778cc