537795 - NSS_InitContext does not work with NSS_RegisterShutdown

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Rich Megginson]

If an application calls NSS_InitContext but not NSS_Initialize, a call to NSS_RegisterShutdown will fail with an error.

Comment 1

[Robert Relyea]

Attachment: Allow NSS_RegisterShutdown and NSS_UnregisterShutdown to be called even when only init'ed by NSS_InitContext()

Comment 2

[Rich Megginson]

Looks good to me

Comment 3

[Robert Relyea]

targetting NSS 3.12.6.

bob

Comment 4

[Wan-Teh Chang]

Comment on attachment 420205 [details] [diff] [review]
Allow NSS_RegisterShutdown and NSS_UnregisterShutdown to be called even when only init'ed by NSS_InitContext()

r=wtc.

We should set SEC_ERROR_NOT_INITIALIZED instead of
SEC_ERROR_LIBRARY_FAILURE in these cases.

Comment 5

[Wan-Teh Chang]

Bob, should we also fix NSS_Shutdown?

Comment 6

[Robert Relyea]

No, NSS_Shutdown should only be called after a regular NSS_Initialize.

RE error code, good catch, I'll include that fix as well when I check it in.

bob

Comment 7

[Robert Relyea]

bobs-laptop(72) cvs commit nssinit.c
Checking in nssinit.c;
/cvsroot/mozilla/security/nss/lib/nss/nssinit.c,v  <--  nssinit.c
new revision: 1.104; previous revision: 1.103
done
bobs-laptop(73)