537834 - Buglist results using atom ctype do not display users with empty real names

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Reed Loden [:reed]]

It seems that if the reporter or assignee does not have a real name set, nothing is displayed in Atom results. If I go to the buglist link in the URL field, I see Atom results like the following:

    <author>
      <name></name>
    </author>
...
      &lt;/tr&gt;&lt;tr class=&quot;bz_feed_reporter&quot;&gt;
        &lt;td&gt;Reporter&lt;/td&gt;
        &lt;td&gt;&lt;/td&gt;

The reporter for bug 537663 does not have a real name set.

Here's some code from buglist.cgi...

    my @email_fields = qw(assigned_to reporter qa_contact);
...
    foreach my $col (@email_fields) {
        my $sql = "map_${col}.login_name";
        if (!Bugzilla->user->id) {
             $sql = $dbh->sql_string_until($sql, $dbh->quote('@'));
        }
        $special_sql{$col} = $sql;
        $columns{"${col}_realname"}->{name} = "map_${col}.realname";
    }

It's only looking at .realname, which can be empty.

Comment 1

[Frédéric Buclin]

That's not what I call a major bug. The realname is not displayed, that's all. If the whole bug was missing from the buglist, this would be another story.

Comment 2

[Reed Loden [:reed]]

(In reply to comment #1)
> That's not what I call a major bug. The realname is not displayed, that's all.
> If the whole bug was missing from the buglist, this would be another story.

Except that if there isn't a realname, _nothing_ is displayed, which can cause problems to people using that format for things.

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> Except that if there isn't a realname, _nothing_ is displayed, which can cause
> problems to people using that format for things.

Nothing as in the guy's identity isn't displayed, or as in the bug is totally missing from the list?

Comment 4

[Reed Loden [:reed]]

(In reply to comment #3)
> Nothing as in the guy's identity isn't displayed, or as in the bug is totally
> missing from the list?

The guy's identity isn't displayed.

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v1

Something like this...

Comment 6

[Frédéric Buclin]

For the record, this bug exists since Bugzilla 2.20, see bug 82878. From what I can read in buglist.cgi line 730, we append required fields for Atom *after* the fallback added at line 705, so bug.assignee and bug.reporter could as well be undefined in the Atom template. Please check this point.

Comment 7

[Reed Loden [:reed]]

Attachment: patch - v2

Indeed, added reporter and assigned_to to that list and tested it on landfill. Works.

Comment 8

[Max Kanat-Alexander]

Comment on attachment 420008 [details] [diff] [review]
patch - v2

Those need to be email-filtered, no?

Comment 9

[Reed Loden [:reed]]

(In reply to comment #8)
> (From update of attachment 420008 [details] [diff] [review])
> Those need to be email-filtered, no?

I don't think it needs to be, no, as Util::email_filter() just does the same thing that the buglist.cgi does earlier:
        if (!Bugzilla->user->id) {
             $sql = $dbh->sql_string_until($sql, $dbh->quote('@'));
        }

Is there some other use case of which I should be aware that would apply here?

Comment 10

[Reed Loden [:reed]]

(In reply to comment #9)
> I don't think it needs to be, no, as Util::email_filter() just does the same
> thing that the buglist.cgi does earlier:

s/the/this/

Comment 11

[Max Kanat-Alexander]

(In reply to comment #9)
> Is there some other use case of which I should be aware that would apply here?

  Ah, no, that handles it. That should be fine. :-)

Comment 12

[Frédéric Buclin]

Comment on attachment 420008 [details] [diff] [review]
patch - v2

r=Lpsolit

Comment 13

[Frédéric Buclin]

You will have to fix the bitrot for 3.4. You use so many context lines that you catch unrelated changes.

Comment 14

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified buglist.cgi
modified template/en/default/list/list.atom.tmpl
Committed revision 7033.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified buglist.cgi
modified template/en/default/list/list.atom.tmpl
Committed revision 7005.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.4/                         
modified buglist.cgi
modified template/en/default/list/list.atom.tmpl
Committed revision 6732.