Disable the "Reset" checkbox for the maintainer parameter

RESOLVED FIXED in Bugzilla 3.6

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mkanat, Assigned: reed)

Tracking

3.5.2
Bugzilla 3.6
Bug Flags:
approval +
approval3.6 +
blocking3.6 +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Since "maintainer" can no longer validly be reset, there shouldn't be an active reset checkbox for it.
Flags: blocking3.6+
(Assignee)

Comment 1

9 years ago
Created attachment 420215 [details] [diff] [review]
wip
Assignee: administration → reed
Status: NEW → ASSIGNED
(Reporter)

Comment 2

9 years ago
Comment on attachment 420215 [details] [diff] [review]
wip

This looks good so far, though you probably want to check $i->{'no_reset'}'s value, not just whether it exists.

Comment 3

9 years ago
(In reply to comment #2)
> This looks good so far, though you probably want to check $i->{'no_reset'}'s
> value, not just whether it exists.

This just means removing "exists" in front of $i->{'no_reset'}. Anything else required before you request review, reed?
(Assignee)

Comment 4

9 years ago
Created attachment 425870 [details] [diff] [review]
patch - v1
Attachment #420215 - Attachment is obsolete: true
Attachment #425870 - Flags: review?(mkanat)
(Reporter)

Comment 5

9 years ago
Comment on attachment 425870 [details] [diff] [review]
patch - v1

Looks good to me.

Probably don't need quotes around the no_reset value in General.pm.
Attachment #425870 - Flags: review?(mkanat) → review+
(Reporter)

Updated

9 years ago
Flags: approval3.6+
Flags: approval+
(Assignee)

Comment 6

9 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified editparams.cgi
modified Bugzilla/Config/General.pm
modified template/en/default/admin/params/common.html.tmpl
Committed revision 6978.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified editparams.cgi
modified Bugzilla/Config/General.pm
modified template/en/default/admin/params/common.html.tmpl
Committed revision 6971.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.