537846 - Disable the "Reset" checkbox for the maintainer parameter

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Max Kanat-Alexander]

Since "maintainer" can no longer validly be reset, there shouldn't be an active reset checkbox for it.

Comment 1

[Reed Loden [:reed]]

Attachment: wip

Comment 2

[Max Kanat-Alexander]

Comment on attachment 420215 [details] [diff] [review]
wip

This looks good so far, though you probably want to check $i->{'no_reset'}'s value, not just whether it exists.

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> This looks good so far, though you probably want to check $i->{'no_reset'}'s
> value, not just whether it exists.

This just means removing "exists" in front of $i->{'no_reset'}. Anything else required before you request review, reed?

Comment 4

[Reed Loden [:reed]]

Attachment: patch - v1

Comment 5

[Max Kanat-Alexander]

Comment on attachment 425870 [details] [diff] [review]
patch - v1

Looks good to me.

Probably don't need quotes around the no_reset value in General.pm.

Comment 6

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified editparams.cgi
modified Bugzilla/Config/General.pm
modified template/en/default/admin/params/common.html.tmpl
Committed revision 6978.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified editparams.cgi
modified Bugzilla/Config/General.pm
modified template/en/default/admin/params/common.html.tmpl
Committed revision 6971.