537887 - The flag setter should be able to unset a flag even if not in the request group

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Reed Loden [:reed]]

Attachment: patch - v1

In bug 533397, I requested approval1.9.2 on a patch back when it wasn't under a request group. Now that it has a request group set on the flag, I can no longer unset the flag.

This seems to be a problem in the initial implementation in bug 348518. From bug 348518, comment #3:
"Also, the logic always provides UI for clearing a flag, even if users aren't
authorized to do (i.e. they don't have set flag privileges for flags in the +
and - states or request flag privileges for flags in the ? state).  The logic
should only provide UI for clearing a flag when the user is authorized to do
so."

I disagree with this. The description for "Request Group" in editflagtypes.cgi is "if flags of this type are requestable, the group allowed to request them (to allow all users to request these flags, select no group)". Nothing in that means that users should not be able to unset such flags.

This patch allows anybody with editbugs to unset flags that are already set but are restricted to some request group.

Comment 1

[Frédéric Buclin]

Comment on attachment 420039 [details] [diff] [review]
patch - v1

No, I don't want to let everybody, even those with editbugs privs, clear flags if they aren't in the request_group. This is to avoid people from abusing them. It's working so by design.

Comment 2

[Frédéric Buclin]

The only thing I would accept is to let the one who set/requested a flag to remove it, in the case the grant/request groups changed meanwhile.

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v2

Very well... at least that will allow me to unset the flag. :)

Comment 4

[Reed Loden [:reed]]

Comment on attachment 420046 [details] [diff] [review]
patch - v2

I always forget that templates have a code backend that actually does work, too. ;)

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v3

Ok, I think this should work.

Comment 6

[Frédéric Buclin]

Comment on attachment 420057 [details] [diff] [review]
patch - v3

r=LpSolit

Comment 7

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/                       
modified Bugzilla/Flag.pm
modified template/en/default/flag/list.html.tmpl
Committed revision 7000.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/                         
modified Bugzilla/Flag.pm
modified template/en/default/flag/list.html.tmpl
Committed revision 6978.