538008 - SSLTunnel won't startup if a previous instance was killed with sockets still opened

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Dave Townsend [:mossop]]

If SSLTunnel is killed when it still has some connections opened then the connections are closed but (at least on linux) remain in the TIME_WAIT state for a short time. This stops a subsequent instance of SSLTunnel from starting as it fails to bind to the still open socket. We can avoid this by setting the SO_REUSEADDR option before attempting to bind. This will allow rebinding an existing socket in the TIME_WAIT state. The alternative would be delaying for short times if unable to bind but this seems the most elegant solution.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Simple fix, just sets the Reuseaddr option on the socket before binding.

Comment 2

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/ba97f3c9d887

Comment 3

[Serge Gautherie (:sgautherie)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/6310c1f176c3

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/72250ea35630