538096 - Use branding to show about:fennec or about:firefox

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Bug 538035 removed about:fennec URI. This patch switches between about:fennec and about:firefox based on branding.

Comment 1

[Gervase Markham [:gerv]]

Desktop Firefox doesn't have an about:firefox, does it? (At least, my 3.6b4 doesn't have it.) So is this a completely new thing for mobile? What's the content on the page? 

I'm not sure it's helpful to have exactly one of about:minefield, about:namoroka, about:firefox and about:fennec work in different builds. The removal of "firefox" from unbranded builds is not total. For example, the executable is still called "firefox". So it's not an absolute requirement that we have this URL be variable.

Gerv

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #1)
> Desktop Firefox doesn't have an about:firefox, does it? (At least, my 3.6b4
> doesn't have it.) So is this a completely new thing for mobile? What's the
> content on the page? 

Yes, it's mobile specific - content is http://mxr.mozilla.org/mobile-browser/source/chrome/content/about.xhtml (mostly just links to other pages).

> The removal of "firefox" from unbranded builds is not total. For example, the
> executable is still called "firefox". So it's not an absolute requirement that
> we have this URL be variable.

Though that specific example doesn't apply to mobile (our executable is always "fennec"), I agree. I think we should just WONTFIX this, especially considering that since this file is used to seed profiles, this patch wouldn't help people who create their profile with an unbranded build and use it with a branded one (or vice versa).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 420276 [details] [diff] [review]
patch

...and if we were to fix this, we shouldn't do it by moving the information into a localized file (since these values shouldn't be localized). We should just put the ifdef in bookmarks.json.in if it comes to it.

Comment 4

[Gervase Markham [:gerv]]

Now I see the content, this looks basically like what we call "about:" (i.e. no suffix) in desktop builds. Is there any reason it couldn't be called that?

Gerv

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

We already have an "about:" and it shows different content than "about:fennec" / "about:firefox"

Comment 6

[BMO Automation]

Closing all opened bug in a graveyard component