Closed Bug 538144 Opened 10 years ago Closed 10 years ago

"configure: line 18450: NS_HILDONFM: command not found"

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(status1.9.2 unaffected)

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- unaffected

People

(Reporter: sgautherie, Assigned: turuoka.bmo)

References

()

Details

Attachments

(1 file)

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262774750.1262781171.18213.gz&fulltext=1
OS X 10.5.2 mozilla-central build on 2010/01/06 02:45:50
{
checking for conic... checking for libhildonmime... checking for libosso... checking for hildon-fm-2... /builds/slave/mozilla-central-macosx/build/configure: line 18450: NS_HILDONFM: command not found
}

http://tinderbox.mozilla.org/showlog.cgi?log=Thunderbird/1262768093.1262776913.2276.gz&fulltext=1
MacOSX 10.5 comm-central build on 2010/01/06 00:54:53
Same.

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1262768113.1262771771.8722.gz&fulltext=1
OS X 10.5 comm-central-trunk build on 2010/01/06 00:55:13
No error: not sure why.

NB: I didn't check Linux and Windows.
Attached patch Patch v1.0Splinter Review
Attachment #421247 - Flags: review?(ted.mielczarek)
Comment on attachment 421247 [details] [diff] [review]
Patch v1.0

Nice catch, thanks!
Attachment #421247 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → turuoka
Keywords: checkin-needed
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 421247 [details] [diff] [review]
Patch v1.0


"approval1.9.2.1=?":
Zero risk, build config typo.
Attachment #421247 - Flags: approval1.9.2.1?
Flags: in-testsuite-
Comment on attachment 421247 [details] [diff] [review]
Patch v1.0

Build config change, should take when the tree re-opens for 1.9.2.3
Attachment #421247 - Flags: approval1.9.2.3?
Attachment #421247 - Flags: approval1.9.2.2?
Attachment #421247 - Flags: approval1.9.2.2-
Comment on attachment 421247 [details] [diff] [review]
Patch v1.0

a=LegNeato for 1.9.2.5. Please ONLY land this on mozilla-1.9.2 default, as we
are still working on 1.9.2.4 on the relbranch
Attachment #421247 - Flags: approval1.9.2.4? → approval1.9.2.5+
Attachment #421247 - Flags: approval1.9.2.5+ → approval1.9.2.6+
1.9.2's configure.in does not have this code, so it's not affected (I guess).
Attachment #421247 - Flags: approval1.9.2.6+
(In reply to comment #8)
> 1.9.2's configure.in does not have this code, so it's not affected (I guess).

Ftr, m-1.9.2 doesn't have this code anymore, because bug 543976 removed it in the meantime.
Depends on: 543976
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.