538187 - CSS changes for :-moz-window-inactive pseudoclass

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

After bug 508482, activating a window will no longer set the "active" attribute on the window, but instead make the new :-moz-window-inactive pseudoclass match. We need to update our CSS for the new behavior.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 420342 [details] [diff] [review]
v1

>--- a/toolkit/themes/winstripe/global/menu.css
>+++ b/toolkit/themes/winstripe/global/menu.css
>@@ -164,16 +164,22 @@ menubar > menu:-moz-lwtheme:not([disable
> }
> 
> menubar > menu:-moz-lwtheme[_moz-menuactive="true"]:not([disabled="true"]) {
>   background-color: Highlight;
>   color: HighlightText !important;
>   text-shadow: none;
> }
> 
>+%ifdef XP_WIN
>+menubar > menu:-moz-window-inactive {
>+  color: ThreeDShadow;
>+}
>+%endif

Need to make sure this file gets preprocessed.

Comment 2

[Markus Stange [:mstange]]

Attachment: v2

Comment 3

[Markus Stange [:mstange]]

Attachment: v3

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 432213 [details] [diff] [review]
v3

Oh, I probably need to update this for bug 480178.

Comment 5

[Markus Stange [:mstange]]

Attachment: v4

Comment 6

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/421874655339

Comment 7

[pal-moz]

sorry if wrong place,

see http://forums.mozillazine.org/viewtopic.php?p=8984055#p8984055
above issue is caused by this bug and/or bug 508482 ?
if so, intended issue ?

Comment 8

[Markus Stange [:mstange]]

Not intended. Please file a bug.

Comment 9

[pal-moz]

filed, bug 554061