Closed Bug 538187 Opened 10 years ago Closed 10 years ago

CSS changes for :-moz-window-inactive pseudoclass

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 3.7a4

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached patch v1 (obsolete) — Splinter Review
After bug 508482, activating a window will no longer set the "active" attribute on the window, but instead make the new :-moz-window-inactive pseudoclass match. We need to update our CSS for the new behavior.
Comment on attachment 420342 [details] [diff] [review]
v1

>--- a/toolkit/themes/winstripe/global/menu.css
>+++ b/toolkit/themes/winstripe/global/menu.css
>@@ -164,16 +164,22 @@ menubar > menu:-moz-lwtheme:not([disable
> }
> 
> menubar > menu:-moz-lwtheme[_moz-menuactive="true"]:not([disabled="true"]) {
>   background-color: Highlight;
>   color: HighlightText !important;
>   text-shadow: none;
> }
> 
>+%ifdef XP_WIN
>+menubar > menu:-moz-window-inactive {
>+  color: ThreeDShadow;
>+}
>+%endif

Need to make sure this file gets preprocessed.
Attached patch v2 (obsolete) — Splinter Review
Attachment #420342 - Attachment is obsolete: true
Attached patch v3 (obsolete) — Splinter Review
Attachment #420359 - Attachment is obsolete: true
Attachment #432213 - Flags: review?(dao)
Attachment #432213 - Attachment is obsolete: true
Attachment #432213 - Flags: review?(dao)
Comment on attachment 432213 [details] [diff] [review]
v3

Oh, I probably need to update this for bug 480178.
Attached patch v4Splinter Review
Attachment #432216 - Flags: review?(dao)
Attachment #432216 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/421874655339
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a4
sorry if wrong place,

see http://forums.mozillazine.org/viewtopic.php?p=8984055#p8984055
above issue is caused by this bug and/or bug 508482 ?
if so, intended issue ?
Not intended. Please file a bug.
filed, bug 554061
Depends on: 554061
Depends on: 554311
You need to log in before you can comment on or make changes to this bug.