Status

()

Core
JavaScript Engine
VERIFIED FIXED
8 years ago
7 years ago

People

(Reporter: bz, Assigned: jorendorff)

Tracking

({relnote, verified1.9.2})

Trunk
x86
Mac OS X
relnote, verified1.9.2
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.9.2 -

Firefox Tracking Flags

(status1.9.2 .2-fixed)

Details

(Whiteboard: [3.6.x][rc-ridealong][fixed-in-tracemonkey])

Attachments

(1 attachment)

Bug 533481 made it so workers use separate debugger hooks so we don't call into jsd.  Bug 519719 made it so that we disable the jit on contexts that don't have the runtime's debug hooks.  Result: no jit in workers.
Flags: blocking1.9.2?
Not a release blocker, but we'll relnote it for sure and take it if we do a RC2 or otherwise in 3.6.1, so let's get the fix together.
Flags: blocking1.9.2? → blocking1.9.2-
Keywords: relnote
Whiteboard: [3.6.x][rc-ridealong]
(Assignee)

Comment 2

8 years ago
Created attachment 420832 [details] [diff] [review]
v1
Assignee: general → jorendorff
That looks like it should do the trick, yes.  Want testing or reviews or anything?
(Assignee)

Comment 4

8 years ago
Yes, a test is needed for this.
(Assignee)

Comment 5

8 years ago
Comment on attachment 420832 [details] [diff] [review]
v1

Nobody can think of a good way to test this. Let's get it in, I guess. :-P
Attachment #420832 - Flags: review?(mrbkap)

Updated

8 years ago
Attachment #420832 - Flags: review?(mrbkap) → review+
Comment on attachment 420832 [details] [diff] [review]
v1

Thanks.
Add a js_OnTrace friend API, add a method to DOMWindowUtils that gets called in a loop to check that JITting happens?  Hackish, but adequate.

Comment 8

8 years ago
So this didn't make to rc2 after all?
That's right.
(Assignee)

Comment 10

8 years ago
http://hg.mozilla.org/tracemonkey/rev/502c0b415e10
Whiteboard: [3.6.x][rc-ridealong] → [3.6.x][rc-ridealong][fixed-in-tracemonkey]
Attachment #420832 - Flags: approval1.9.2.1?

Comment 11

8 years ago
http://hg.mozilla.org/mozilla-central/rev/502c0b415e10
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Comment on attachment 420832 [details] [diff] [review]
v1

a1922=beltzner
Attachment #420832 - Flags: approval1.9.2.2? → approval1.9.2.2+
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/858dc58eceee
status1.9.2: --- → .2-fixed
Is there an easy way for QA to verify this for 1.9.2 and Trunk?
You could run some script with loops in a worker and see how jitstats are affected (or not) in a debug build....  Or just measure the performance of that script with jit on and off and see whether there's an effect.

Comment 16

7 years ago
my addon that uses worker threads runs over 2x faster in 3.6.2 than 3.6 (non-debug), so I can only assume they're being jited.
Verified! :)
Status: RESOLVED → VERIFIED
I agree at this point.
Keywords: verified1.9.2
so I guess there were other things that could have sped up workers in 3.6.2, but yeah, trying with jit on/off on the same build has the same speedup.
Hi harthur,

Just out of curiosity, which addon is it?
https://addons.mozilla.org/en-US/firefox/addon/14328, the thing that uses web workers is the 'website analyzer'.
Depends on: 562455

Comment 22

7 years ago
Hi,

The issue still exist in the current release 3.6.10. Javascript engine can't capture the user change efficiently. 

Only version 3.5.9 firefox is running fine but all above versions have the same issue.

Zafar

Comment 23

7 years ago
Here is the case:

If user remove the character or characters from text field and then enter character and save them (repeat quickly several time), it won't capture the last change.

Zafar
Zafar, that sounds completely unrelated to this bug.  Please file a separate bug on your problem.
You need to log in before you can comment on or make changes to this bug.