Allow ToInteger to take an nsresult* parameter

RESOLVED FIXED

Status

()

defect
--
trivial
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: neil, Assigned: neil)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In the external string API, ToInteger takes an nsresult* parameter, which makes sense, since the result could be NS_ERROR_ILLEGAL_VALUE. However for historical sreason the internal API takes a PRInt32*. It should at least be possible to compile a module using an nsresult parameter using either string API.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #420628 - Flags: review?(benjamin)
Attachment #420628 - Flags: review?(benjamin) → review+
Pushed changeset 0124df25702b to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 420628 [details] [diff] [review]
Proposed patch

It would be nice if this API could be added to the 1.9.2 branch as it would ease the porting of Thunderbird to libxul.
Attachment #420628 - Flags: approval1.9.2.1?
Comment on attachment 420628 [details] [diff] [review]
Proposed patch

This missed 1.9.2.2, moving flag to 1.9.2.3
Attachment #420628 - Flags: approval1.9.2.2? → approval1.9.2.3?
Comment on attachment 420628 [details] [diff] [review]
Proposed patch

Clearing old approval requests now that 1.9.2.4 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.
Attachment #420628 - Flags: approval1.9.2.4?
Depends on: post2.0
No longer depends on: post2.0
Blocks: 644963
You need to log in before you can comment on or make changes to this bug.