In the external string API, ToInteger takes an nsresult* parameter, which makes sense, since the result could be NS_ERROR_ILLEGAL_VALUE. However for historical sreason the internal API takes a PRInt32*. It should at least be possible to compile a module using an nsresult parameter using either string API.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #420628 - Flags: review?(benjamin)
Pushed changeset 0124df25702b to mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Comment on attachment 420628 [details] [diff] [review] Proposed patch It would be nice if this API could be added to the 1.9.2 branch as it would ease the porting of Thunderbird to libxul.
Attachment #420628 - Flags: approval188.8.131.52?
Comment on attachment 420628 [details] [diff] [review] Proposed patch This missed 184.108.40.206, moving flag to 220.127.116.11
Attachment #420628 - Flags: approval18.104.22.168? → approval22.214.171.124?
Comment on attachment 420628 [details] [diff] [review] Proposed patch Clearing old approval requests now that 126.96.36.199 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.
Attachment #420628 - Flags: approval188.8.131.52?
You need to log in before you can comment on or make changes to this bug.