Closed
Bug 538476
Opened 15 years ago
Closed 15 years ago
Allow ToInteger to take an nsresult* parameter
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
2.19 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
In the external string API, ToInteger takes an nsresult* parameter, which makes sense, since the result could be NS_ERROR_ILLEGAL_VALUE. However for historical sreason the internal API takes a PRInt32*. It should at least be possible to compile a module using an nsresult parameter using either string API.
|
Assignee | |
Comment 1•15 years ago
|
||
|
||
Updated•15 years ago
|
Attachment #420628 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Pushed changeset 0124df25702b to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•15 years ago
|
||
Comment on attachment 420628 [details] [diff] [review]
Proposed patch
It would be nice if this API could be added to the 1.9.2 branch as it would ease the porting of Thunderbird to libxul.
Attachment #420628 -
Flags: approval1.9.2.1?
|
||
Comment 4•15 years ago
|
||
Comment on attachment 420628 [details] [diff] [review]
Proposed patch
This missed 1.9.2.2, moving flag to 1.9.2.3
Attachment #420628 -
Flags: approval1.9.2.2? → approval1.9.2.3?
|
||
Comment 5•14 years ago
|
||
Comment on attachment 420628 [details] [diff] [review]
Proposed patch
Clearing old approval requests now that 1.9.2.4 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.
Attachment #420628 -
Flags: approval1.9.2.4?
You need to log in
before you can comment on or make changes to this bug.
Description
•