538581 - Fix software update tests for fallback updates and version check

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the latest test runs against the betatest channel for testing the update to 3.6RC1 two issues have been shown which needs to be fixed.

1. The update.status file should contain a "failed: 6". ATM the whitespace is missing.

2. We need a better version check. While testing official releases we do not have a problem because no version prefix is used. But now with the update path from 3.6b5 to 3.6 a normal string comparison is not sufficient anymore.

Dave, could you please point me to the code for the Addons Manager which is used for version comparison? I believe that I can use the identical way.

Comment 1

[Robert Strong (they/them - no direct email)]

The version comparison is performed using nsIVersionComparator.

One example in the em
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#5682

One example in app update
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#1255

I don't know if this affects you but nightly builds without a version bump will have the same version.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #1)
> The version comparison is performed using nsIVersionComparator.
> 
> One example in app update
> http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/src/nsUpdateService.js.in#1255
> 
> I don't know if this affects you but nightly builds without a version bump will
> have the same version.

That one is pretty helpful. Thanks Rob! In case of the updates which do not result in a version change I will take the buildID as an indicator that the update was successful.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

This fixes the version comparison problems we had before and correctly mark the downloaded update as failed.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/6dab704be36c
http://hg.mozilla.org/qa/mozmill-tests/rev/8c255f721fcc

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.