Closed Bug 538585 Opened 10 years ago Closed 10 years ago

Using the Weave menu from the status bar moves the window

Categories

(Toolkit :: XUL Widgets, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: hsivonen, Assigned: enndeakin)

Details

Attachments

(1 file)

Firefox: trunk
Weave: 1.0rc

Steps to reproduce:
 1) Install and set up Weave.
 2) Click and hold the Weave icon in the status bar so that a popup menu opens.
 3) Drag vertically into the menu.
 4) Move the mouse horizontally within the menu.

Actual results:
The mouse movement moves the browser window.

Expected results:
Expected the window not to move and the gesture only to work as menu browsing.
This is a fun interaction between menubutton elements and draggable elements... I'll let Neil make a call on this.
Component: Firefox UI → XUL Widgets
Product: Weave → Toolkit
QA Contact: firefox → xul.widgets
This fixes the bug, but why isn't this menu just using the 'popup' attribute?

I'll add a test as part of a patch in a different bug.
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #422656 - Flags: review?(neil)
(In reply to comment #2)
> Created an attachment (id=422656)
> don't drag the window if the mousedown event was cancelled
> 
> This fixes the bug, but why isn't this menu just using the 'popup' attribute?
Or better still, use a statusbarpanel-menu-iconic.
Comment on attachment 422656 [details] [diff] [review]
don't drag the window if the mousedown event was cancelled

Was it your intention to block the mousemove and mouseup events too?
Yes, although on second thought, I think it would be better not to for mouseup, to ensure that the event listener is removed properly.
The test is in the patch in bug 536625.
Comment on attachment 422656 [details] [diff] [review]
don't drag the window if the mousedown event was cancelled

Alternatively you could guarantee the mouseup (or mousemove) handlers by making them capturing.
Attachment #422656 - Flags: review?(neil) → review+
http://hg.mozilla.org/mozilla-central/rev/be38c78eb674
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite+
Dragging text in locationbar breaks caret. One of the 4 changesets has possibly caused this.
You need to log in before you can comment on or make changes to this bug.