538585 - Using the Weave menu from the status bar moves the window

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Henri Sivonen (:hsivonen)]

Firefox: trunk
Weave: 1.0rc

Steps to reproduce:
 1) Install and set up Weave.
 2) Click and hold the Weave icon in the status bar so that a popup menu opens.
 3) Drag vertically into the menu.
 4) Move the mouse horizontally within the menu.

Actual results:
The mouse movement moves the browser window.

Expected results:
Expected the window not to move and the gesture only to work as menu browsing.

Comment 1

[Mike Connor [:mconnor]]

This is a fun interaction between menubutton elements and draggable elements... I'll let Neil make a call on this.

Comment 2

[Neil Deakin]

Attachment: don't drag the window if the mousedown event was cancelled

This fixes the bug, but why isn't this menu just using the 'popup' attribute?

I'll add a test as part of a patch in a different bug.

Comment 3

[[e-mail]]

(In reply to comment #2)
> Created an attachment (id=422656)
> don't drag the window if the mousedown event was cancelled
> 
> This fixes the bug, but why isn't this menu just using the 'popup' attribute?
Or better still, use a statusbarpanel-menu-iconic.

Comment 4

[[e-mail]]

Comment on attachment 422656 [details] [diff] [review]
don't drag the window if the mousedown event was cancelled

Was it your intention to block the mousemove and mouseup events too?

Comment 5

[Neil Deakin]

Yes, although on second thought, I think it would be better not to for mouseup, to ensure that the event listener is removed properly.

Comment 6

[Neil Deakin]

The test is in the patch in bug 536625.

Comment 7

[[e-mail]]

Comment on attachment 422656 [details] [diff] [review]
don't drag the window if the mousedown event was cancelled

Alternatively you could guarantee the mouseup (or mousemove) handlers by making them capturing.

Comment 8

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/be38c78eb674

Comment 9

[Ria Klaassen (not reading all bugmail)]

Dragging text in locationbar breaks caret. One of the 4 changesets has possibly caused this.