538589 - Set up Reminder dialog. The remove button removes the reminder following the selected one in the list

Status: RESOLVED FIXED

(Calendar :: Alarms, defect)

Description

[Decathlon]

Reproducible:
Always


Steps to Reproduce:
1. create a new event and select Reminder -> Custom...;
2. add two or more events to the reminder list with different length or 
   settings (only to recognize them);
3. select a reminder in the list;
4. press the "Remove" button.


Actual Results:
the removed reminder is that one that follows the selected one in the list. If the last reminder is selected, the last but one is deleted.

Expected Results:
Should be removed the selected reminder.

Comment 1

[Decathlon]

Attachment: [short] fix-v1

The function onRemoveReminder() (file calendar-event-dialog-reminder.js) deletes the correct reminder, but when selects the next one, the function onReminderSelected() is called. Here, when |relationType| is assiged [1], the reminder gets all the settings from the dialog controls, that actually still belong to the deleted reminder.
Hence, the reminder following the selected one becomes the deleted reminder and looks like the old reminder has never been removed.

[1] http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog-reminder.js#268

The proposal patch prevents to update the next reminder with the values of the dialog controls if we are removing the selected reminder from the list.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 420795 [details] [diff] [review]
[short] fix-v1

Looks good, r=philipp

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c01d3c82ff6f>

-> FIXED