Closed
Bug 538592
Opened 15 years ago
Closed 15 years ago
record_JSOP_CALLPROP seems to test the property cache twice
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Unassigned)
References
Details
In particular, it does a test_property_cache itself, then calls getProp which does another test. Are they actually doing different tests? If not, could we reuse the results somehow? On the testcase in bug 536564 that extra test is about 5% of recording time (so about 0.75% of total time).
|
||
Comment 1•15 years ago
|
||
bz, this double test happens only with the path for bug 536564. I will work on refactoring to avoid the double test in that bug. Want to keep this one around still?
/be
|
|
Reporter | |
Comment 2•15 years ago
|
||
Either way; whatever is simplest.
|
|
||
Comment 3•15 years ago
|
||
Fixed in last few patches for bug 536564, never committed anywhere, this bug is pre-FIXED or pre-INVALID, take your pick ;-).
/be
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•