make IE profile migration not use #import

RESOLVED FIXED in Firefox 3.7a1

Status

()

Firefox
Migration
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Mitch, Assigned: ted)

Tracking

Trunk
Firefox 3.7a1
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
pstore.h can be included instead of importing pstorec.dll. Patch from ted imminent.

(http://msdn.microsoft.com/en-us/library/bb432323%28VS.85%29.aspx)
(Reporter)

Updated

8 years ago
Assignee: nobody → ted.mielczarek
Blocks: 428532
Status: NEW → ASSIGNED
(Assignee)

Comment 1

8 years ago
Specifically, this breaks compiling with Visual C++'s -MP flag, which bug 428532 intends to do. Patch is pretty trivial.
Component: Build Config → Migration
Product: Core → Firefox
QA Contact: build-config → migration
(Assignee)

Updated

8 years ago
Summary: Remove a horrible typelib #import → make IE profile migration not use #import
(Assignee)

Comment 2

8 years ago
Created attachment 420760 [details] [diff] [review]
use #include instead, fix a little bit of fallout

This works for me. Just required a little bit of cleanup for some pointer type names that aren't explicitly defined in the header file.
(Assignee)

Updated

8 years ago
Attachment #420760 - Flags: review?(gavin.sharp)
Attachment #420760 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

8 years ago
Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/e7633625eabd
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
You need to log in before you can comment on or make changes to this bug.