Open Bug 538672 Opened 14 years ago Updated 8 months ago

browser_506482.js | tab selection and scrolling: sessionstore.js not updated

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect

Tracking

()

Milestone:
Firefox 3.7a1

People

(Reporter: zpao, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled])

Attachments

(1 file)

increase timeouts (checked in)
689 bytes, patch
zpao
: review+
Details | Diff | Splinter Review 
Looks like a bit of orange, though it doesn't look directly related to the test.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1262982506.1262985816.26057.gz
Linux mozilla-central opt test everythingelse on 2010/01/08 12:28:26

Running chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js...
TEST-INFO | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | Console message: [JavaScript Error: "[Exception... "'JavaScript component does not have a method named: "notify"' when calling method: [nsITimerCallback::notify]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "<unknown>"  data: no]"]
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | initial sessionstore.js update - Didn't expect 1262984097000, but got it
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got 1262984100000, expected 1262984097000

The 'JavaScript component does not have a method named: "notify"' exception also shows up in the logs a few lines up in a previous test, but doesn't seem to affect anything there (that test probably doesn't use setTimeout...)
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263014658.1263020777.3202.gz
OS X 10.5.2 mozilla-central debug test everythingelse on 2010/01/08 21:24:18  
s: moz2-darwin9-slave13
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | initial sessionstore.js update - Didn't expect 1263017363000, but got it
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got 1263017366000, expected 1263017363000
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263039408.1263043007.21317.gz

Running chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js...
NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | initial sessionstore.js update - Didn't expect 1263041512000, but got it
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got 1263041514000, expected 1263041512000
it looks like there is a related failure on windows

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263046137.1263048220.21524.gz

Running chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js...
TEST-INFO | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | Console message: [JavaScript Error: "[Exception... "'JavaScript component does not have a method named: "notify"' when calling method: [nsITimerCallback::notify]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "<unknown>"  data: no]"]
TEST-PASS | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | initial sessionstore.js update
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got -1, expected 1263047095397
For the first 3 logs above, it seems to be the initial 2500ms sleep not being long enough.  That's weird, because addTab() should trigger an update with a 2000ms timer.  It could have been because of a previous test having triggered a longer timer already, but there is a setIntPref on "browser.sessionstore.interval" which is supposed to avoid exactly that (it should have canceled any previous timer).  
Anyway, we should try increasing the first sleep a bit, to say 3500ms, and see what happens. I will attach a patch.

The last log, from comment #3, is different, I don't understand it. The TEST-PASS on "initial sessionstore.js update" indicates that sessionstore.js exists, but then the "Got -1, expected 1263047095397" is like it did disappear...

Finally, about the Exception message, I can reproduce it when launching the whole sessionstore tests suite (but not when launching browser_506482.js alone), but here it doesn't lead to any test failure.
Increased both timers to 3.5 secs, since it seems 2.5 secs was a bit optimistic.
Attachment #420908 - Flags: review?(paul)
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263072256.1263075052.26306.gz
Linux mozilla-central opt test everythingelse on 2010/01/09 13:24:16
s: moz2-linux-slave23
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263078859.1263080812.23890.gz
WINNT 5.2 mozilla-central opt test everythingelse on 2010/01/09 15:14:19
s: win32-slave40
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got -1, expected 1263079685250
Linux mozilla-central opt test everythingelse [testfailed] Started 12:13, finished 13:15
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263240804.1263244491.3413.gz&fulltext=1
Comment on attachment 420908 [details] [diff] [review]
increase timeouts (checked in)

Hopefully this makes it better. Thanks Thomas
Attachment #420908 - Flags: review?(paul) → review+
WINNT 5.2 mozilla-central opt test everythingelse [testfailed] Started 14:18, finished 14:57
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263248318.1263250471.4036.gz&fulltext=1
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263257665.1263259563.8005.gz
WINNT 5.2 mozilla-central opt test everythingelse on 2010/01/11 16:54:25
s: win32-slave25
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got -1, expected 1263258420000
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263300676.1263307762.26105.gz
WINNT 5.2 mozilla-central debug test everythingelse on 2010/01/12 04:51:16  
s: win32-slave29
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | initial sessionstore.js update - Didn't expect 1263303474000, but got it
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got 1263303476000, expected 1263303474000
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263339076.1263340997.12914.gz
WINNT 5.2 mozilla-central opt test everythingelse on 2010/01/12 15:31:16  
s: win32-slave16
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got -1, expected 1263339864000
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263385018.1263388644.18303.gz
Linux mozilla-central opt test everythingelse on 2010/01/13 04:16:58
s: moz2-linux-slave24
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | initial sessionstore.js update - Didn't expect 1263387115000, but got it
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got 1263387118000, expected 1263387115000
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263395353.1263403431.28427.gz
Linux mozilla-central debug test everythingelse on 2010/01/13 07:09:13
s: moz2-linux-slave24
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263424487.1263428947.21200.gz
Linux mozilla-central opt test everythingelse on 2010/01/13 15:14:47
s: moz2-linux-slave22
Pushed http://hg.mozilla.org/mozilla-central/rev/7f1dc91b2909. I'll leave this open for now in case this wasn't enough.
QA Contact: session.restore → tom.gl
Target Milestone: --- → Firefox 3.7a1
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263478187.1263480309.8210.gz

Running chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js...
TEST-INFO | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | Console message: [JavaScript Error: "[Exception... "'JavaScript component does not have a method named: "notify"' when calling method: [nsITimerCallback::notify]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "<unknown>"  data: no]"]
TEST-PASS | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | initial sessionstore.js update
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got -1, expected 1263479191588
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263511217.1263511744.3396.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/14 15:20:17
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263588725.1263589828.26272.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/15 12:52:05
s: win32-slave35
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got -1, expected 1263589557766
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263669893.1263670479.13575.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/16 11:24:53
s: win32-slave35
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got -1, expected 1263670302333
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263667802.1263668459.24182.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/16 10:50:02
s: win32-slave32
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got -1, expected 1263668278454
Assignee: nobody → tom.gl
QA Contact: tom.gl → session.restore
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263875816.1263876875.8550.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/18 20:36:56
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1264128390.1264129100.28801.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/21 18:46:30
s: win32-slave37
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got -1, expected 1264128910133
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1264171385.1264172105.13054.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/22 06:43:05
s: win32-slave39
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1264275025.1264275623.25965.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/23 11:30:25
s: win32-slave40
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1264443492.1264444151.26342.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/25 10:18:12
s: win32-slave35
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1264434900.1264435789.28679.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/25 07:55:00
s: win32-slave41
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1264582629.1264583942.23861.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/27 00:57:09
s: win32-slave31
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1264889148.1264889961.4229.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/01/30 14:05:48
s: win32-slave38
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1265293713.1265294450.12773.gz
Summary: browser_506482.js | initial sessionstore.js update → browser_506482.js | tab selection and scrolling: sessionstore.js not updated
Attachment #420908 - Attachment description: browser_506482_js-test_fix-v1.0.patch → increase timeouts (checked in)
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1265348597.1265352344.17320.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/02/04 21:43:17
s: win32-slave27
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1265492120.1265492636.14210.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/02/06 13:35:20
s: win32-slave15
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1265639137.1265641018.12744.gz
OS X 10.5.2 mozilla-central debug test mochitest-other on 2010/02/08 06:25:37
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | initial sessionstore.js update - Didn't expect 1265640498000, but got it
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got 1265640503000, expected 1265640498000
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1265868446.1265869199.1999.gz
Linux mozilla-central opt test mochitest-other on 2010/02/10 22:07:26
s: moz2-linux-slave05
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267079061.1267081502.9195.gz
OS X 10.5.2 mozilla-central debug test mochitest-other on 2010/02/24 22:24:21
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267222831.1267225125.16323.gz
Linux mozilla-central opt test mochitest-other on 2010/02/26 14:20:31
s: moz2-linux-slave26
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267352927.1267353884.20386.gz
Linux mozilla-central opt test mochitest-other on 2010/02/28 02:28:47
s: moz2-linux-slave15
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267403434.1267405348.17626.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/02/28 16:30:34
s: win32-slave18
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267538501.1267541012.23594.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/03/02 06:01:41
s: win32-slave11
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267798511.1267801013.5357.gz
Linux mozilla-central debug test mochitest-other on 2010/03/05 06:15:11
s: moz2-linux-slave02
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1267831247.1267833057.30860.gz
Linux mozilla-central opt test mochitest-other on 2010/03/05 15:20:47
s: moz2-linux-slave13
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268066877.1268068790.14091.gz
Linux mozilla-central opt test mochitest-other on 2010/03/08 08:47:57
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268094693.1268096343.26741.gz
Linux mozilla-central opt test mochitest-other on 2010/03/08 16:31:33
s: moz2-linux-slave01
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268090661.1268093617.19075.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/03/08 15:24:21
s: win32-slave08
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268153820.1268154960.9419.gz
Linux mozilla-central opt test mochitest-other on 2010/03/09 08:57:00
s: moz2-linux-slave41
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268141243.1268143938.4989.gz
WINNT 5.2 mozilla-central opt test mochitest-other on 2010/03/09 05:27:23
s: mw32-ix-slave04
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268177368.1268179484.17232.gz&fulltext=1
Linux mozilla central opt mochitest-other on 2010/03/09 14:24:00 
s: moz2-linux-slave25
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268228577.1268231331.30640.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/03/10 05:42:57
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268554972.1268556332.23206.gz
Linux mozilla-central opt test mochitest-other on 2010/03/14 00:22:52
s: moz2-linux-slave11
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268680281.1268683208.15459.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/03/15 12:11:21
s: win32-slave06
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268709096.1268711368.22136.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/03/15 20:11:36
s: win32-slave43
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268789878.1268792614.17810.gz
WINNT 5.2 mozilla-central debug test mochitest-other on 2010/03/16 18:37:58
s: win32-slave18
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268812409.1268813642.2647.gz
Linux mozilla-central opt test mochitest-other on 2010/03/17 00:53:29
s: moz2-linux-slave10
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268950617.1268951422.5505.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/18 15:16:57
s: moz2-darwin9-slave42
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1268975966.1268977420.5393.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/18 22:19:26
s: moz2-darwin9-slave42

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | initial sessionstore.js update - Didn't expect 1268976993000, but got it
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/browser/components/sessionstore/test/browser/browser_506482.js | tab selection and scrolling: sessionstore.js not updated - Got 1268976996000, expected 1268976993000
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269113126.1269114047.26433.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/20 12:25:26
s: moz2-darwin9-slave38
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269132730.1269133719.30270.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/20 17:52:10
s: moz2-darwin9-slave40
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269202924.1269203727.3971.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/21 13:22:04
s: moz2-darwin9-slave41
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269215490.1269216373.3142.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/21 16:51:30
s: moz2-darwin9-slave42
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269507657.1269508449.16431.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/25 02:00:57  
s: moz2-linux-slave27
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269556229.1269557027.4740.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/25 15:30:29
s: moz2-darwin9-slave43
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269639719.1269640596.15160.gz
Linux mozilla-central opt test mochitest-other on 2010/03/26 14:41:59
s: moz2-linux-slave22
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269640105.1269640902.15920.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/26 14:48:25
s: moz2-darwin9-slave39
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1269981242.1269982010.22316.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/30 13:34:02
s: moz2-darwin9-slave43
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270039578.1270040358.2610.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/03/31 05:46:18
s: moz2-darwin9-slave42
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270191419.1270192177.3906.gz
OS X 10.5.2 mozilla-central opt test mochitest-other on 2010/04/01 23:56:59
s: moz2-darwin9-slave42
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270227835.1270228729.25289.gz
Linux mozilla-central opt test mochitest-other [testfailed] Started 10:03, finished 10:19
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1270624708.1270626594.17829.gz
OS X 10.5.2 mozilla-central debug test mochitest-other on 2010/04/07 00:18:28
s: moz2-darwin9-slave19
Blocks: 558646
Why did we just increase timeouts here?  Why is it timed at all?  We know that timing-based tests are a recipe for non-useful orange. :-(

Thomas: are you still working on this bug?  I think we should disable it until we can write it in a way that's not timing-dependent; this test's false-alarm[*] oranges mean that it's a net loss for our productivity.

[*] of course, that leaves the question: why do we think it's OK for that timer to fire so late?  Why do we think that the timer is what caused the JS error?
(In reply to comment #95)
> Why did we just increase timeouts here?  Why is it timed at all?  We know that
> timing-based tests are a recipe for non-useful orange. :-(

Timing based sucks, but we're testing that an event didn't occur - that the sessionstore file isn't written after doing something. So we wait N to make sure that didn't happen.

> Thomas: are you still working on this bug?  I think we should disable it until
> we can write it in a way that's not timing-dependent; this test's
> false-alarm[*] oranges mean that it's a net loss for our productivity.

I will disable it. It's on my list of things to look at in the immediate future.

> [*] of course, that leaves the question: why do we think it's OK for that timer
> to fire so late?  Why do we think that the timer is what caused the JS error?

I think the real problem is that the file is being written async, and so there's a write finishing after we start the test, which we don't expect. My plan here is to rework this so that we're 100% sure there's no pending write before we start and use the file written observer topic instead of timeouts, at least for when we expect the write to happen.
Assignee: tom.gl → paul
Something else which may be done here is overriding the "@mozilla.org/network/safe-file-output-stream;1" service, and just seeing if that service is being instantiated or not.  It's an ugly hack, but so is the current way of testing this!
Test disabled for now: http://hg.mozilla.org/mozilla-central/rev/0b3c38dad8a7
Whiteboard: [orange] → [orange][test disabled]
Assignee: paul → nobody
Whiteboard: [orange][test disabled] → [test disabled]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.