If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Canceling HTTP auth prompt does not cancel other pending requests for the same host

NEW
Unassigned

Status

()

Core
Networking: HTTP
P5
normal
8 years ago
6 days ago

People

(Reporter: Dolske, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [necko-would-take])

(Reporter)

Description

8 years ago
Bug 475053 added support for asyncPromptAuth; now if session restore opens two tabs requiring authentication for the same host+realm, only 1 prompt is shown and you only need to enter credentials once.

I noticed that if you *cancel* the prompt, you'll then get the prompt again (for the second tab). This isn't desirable.

In fact, what seems to be happening is that the multiple requests for authentication are not actually making it to the code added in 475053 (which explicitly has code for handling this situation, the |consumers| array created in asyncPromptAuth() holds each request for the same host+realm).

So, when Cancel is clicked, we only have one nsIAuthPromptCallback to notify of the cancellation. Even when entering valid credentials, there's only one nsIAuthPromptCallback that gets notified of success.

STR:
1) New profile, set to restore tabs on startup, set signon.debug pref to true
2) Open 2 tabs to a site requesting authentication (eg http://dolske.net/mozilla/tests/httpauth/realmX)
3) Restart browser
4) Click cancel on first authprompt
5) Click cancel on second authpromt

Note debug logging between steps 3 and 5. The auth prompter knows nothing about the second request until after step 4.
-> me
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED

Updated

4 years ago
Blocks: 411085
Assignee: honzab.moz → nobody
Status: ASSIGNED → NEW
Whiteboard: [necko-would-take]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.