Closed
Bug 53875
Opened 24 years ago
Closed 24 years ago
stringBundleBindings.xml uses obsolete <argument> element
Categories
(Core :: XBL, defect, P3)
Core
XBL
Tracking
()
RESOLVED
FIXED
People
(Reporter: jrgmorrison, Assigned: jag+mozbugs)
References
()
Details
(Keywords: regression, Whiteboard: [nsbeta3-][rtm-])
Attachments
(1 file)
|
580 bytes,
patch
|
Details | Diff | Splinter Review |
stringBundleBindings.xml uses obsolete <argument> element, which breaks this
XBL. This needs to be changed to the new <parameter> syntax to make this work
again. nominating: nsbeta3,rtm as this is a simple, safe fix, to make code
work again, with minimum risk (one-line XBL change to conform to new syntax).
8 <implementation name="XStringBundle">
9
10 <method name="getString">
11 <argument name="aStringKey"/>
12 <body>
13 <
|
Reporter | |
Updated•24 years ago
|
We don't need this for beta 3. Why should we stop ship for this? What problem does it cause?
Whiteboard: [nsbeta3-]
|
Assignee | |
Comment 2•24 years ago
|
||
Well, it happens to stop me from using this sexy xbl in the filepicker. Of course, I could just use the regular stringbundle stuff, but this is way sexier (no need to include strres.js everywhere meaning less bloat). And the fix seems to be s/argument/parameter/, for which I'll attach a patch.
|
|
Assignee | |
Comment 4•24 years ago
|
||
nav triage team: we don't see how this effects the user, rtm-
Whiteboard: [nsbeta3-] → [nsbeta3-][rtm-]
Target Milestone: --- → Future
|
|
Assignee | |
Comment 8•24 years ago
|
||
Checked in on the trunk. Since this bug is nsbeta3-, rtm-, I'm going to mark it fixed.
|
|
Assignee | |
Comment 9•24 years ago
|
||
duh, really marking it now.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•