538751 - Port |Bug 537369 - Failed to build with --enable-dtrace for 64bit library| to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Just copy it

Not sure if c-c actually needs all this DTRACE support (in addition to the m-c one):
maintaining it for now.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 420881 [details] [diff] [review]
(Av1) Just copy it

based on c#0 of dependant bug, the -32 flag is not needed at all. So I don't see a need to ifdef this between the two m-c branches.

r+ once you fix that. (would love to give patch a very quick once-over though at that stage)

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Just copy it (for m-1.9.2 too) [Checkin: Comment 6]

Av1, with comment 2 suggestion(s).

(In reply to comment #2)
> based on c#0 of dependant bug, the -32 flag is not needed at all. So I don't
> see a need to ifdef this between the two m-c branches.

Indeed, but not knowing this feature, I preferred to be safe than sorry.

Comment 4

[Ginn Chen]

It works for me without -32 with 32bit libraries.
So I think it is correct.

I think it is not necessary to make it for m-1.9.2 since it is only used by Solaris, on Solaris we usually just build 32bit version for now.

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 420938 [details] [diff] [review]
(Av2) Just copy it (for m-1.9.2 too)
[Checkin: Comment 6]

looks good. fixed 1.9.2 as well when commit please

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 420938 [details] [diff] [review]
(Av2) Just copy it (for m-1.9.2 too)
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/add55c14cf5c