Closed
Bug 538920
Opened 15 years ago
Closed 15 years ago
nsIObserver should be marked "function"
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file, 1 obsolete file)
|
1.01 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
I'm a bit surprised that I would be the first person suggesting this, so maybe I'm missing some reason why it wouldn't work, but bz couldn't think of any either... The goal is to allow JS addObserver callers to just pass in a function object rather than objects with a "notify" method, the same way e.g. nsIDOMEventListener works.
|
Assignee | |
Comment 1•15 years ago
|
||
Works fine. I used http://people.mozilla.com/~gavin/observer-function.diff to test.
|
||
Comment 2•15 years ago
|
||
Comment on attachment 421004 [details] [diff] [review]
patch
This looks like the test and not the patch.
|
|
Assignee | |
Comment 3•15 years ago
|
||
bah, thanks for the heads up :)
Attachment #421004 -
Attachment is obsolete: true
Attachment #421226 -
Flags: review?(benjamin)
Attachment #421004 -
Flags: review?(benjamin)
|
||
Updated•15 years ago
|
Attachment #421226 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•