538929 - Some "system" directories are created with wrong permissions

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Mike Hommey [:glandium]]

nsXREDirProvider::EnsureDirectoryExists creates directories with 0700 permissions, which is fine for most directories, which are to be created in the user profile directory, but there are two cases in nsXREDirProvider where this is wrong:
XRE_SYS_LOCAL_EXTENSION_PARENT_DIR and NS_APP_PREFS_OVERRIDE_DIR.
Either EnsureDirectoryExists should not be used or a new function that creates directories 0755 should be added. Which one would you prefer ? (personally, I'd prefer if mozilla apps would stop writing to the system filesystems altogether, but the present issue is only a small part of that...)

Note that for the former, the quite similar XRE_SYS_SHARE_EXTENSION_PARENT_DIR does *not* use EnsureDirectoryExists.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch

Comment 2

[Mike Hommey [:glandium]]

http://hg.mozilla.org/mozilla-central/rev/cc7dda8df778