Update Service creates updates directory when updates disabled

RESOLVED WORKSFORME

Status

()

defect
RESOLVED WORKSFORME
10 years ago
9 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

1.9.1 Branch
Points:
---

Firefox Tracking Flags

(status1.9.1 wontfix)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

10 years ago
Posted patch patch for 1.9.1 (obsolete) — Splinter Review
(The code is different on trunk, so I don't know if this applies there ; only filing for reference)

When app.update.enabled is false in preferences, the update service still creates the $APPDIR/updates/0 directory, which is pretty pointless.
This happens because the check for the preference and other information is done after the directory is created in the canUpdate getter.

The attached patch moves these checks around.
Assignee

Updated

10 years ago
Attachment #421017 - Attachment is patch: true
Attachment #421017 - Attachment mime type: application/octet-stream → text/plain
OS: Linux → All
Hardware: x86 → All
I believe I already fixed this on trunk and 1.9.2. I doubt you'll get approval for 1.9.1 though you might be able to convince the 1.9.1 drivers.
Assignee

Comment 3

10 years ago
As I wrote in comment #0, I only filed for reference. Other linux distros may want to apply it, for example.
Comment on attachment 421017 [details] [diff] [review]
patch for 1.9.1

Removing r+ so it doesn't interfere with bugzilla queries
Attachment #421017 - Flags: review+
Marking WFM based on comment #2.
Assignee: nobody → mh+mozilla
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
Comment on attachment 421017 [details] [diff] [review]
patch for 1.9.1

Doesn't hurt to ask...
Attachment #421017 - Flags: approval1.9.1.11?
Assignee

Comment 7

9 years ago
Comment on attachment 421017 [details] [diff] [review]
patch for 1.9.1

Except the patch doesn't apply anymore
Attachment #421017 - Flags: approval1.9.1.11?
Assignee

Comment 8

9 years ago
For those interested.
Attachment #421017 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.