538933 - Update Service creates updates directory when updates disabled

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[Mike Hommey [:glandium]]

Attachment: patch for 1.9.1

(The code is different on trunk, so I don't know if this applies there ; only filing for reference)

When app.update.enabled is false in preferences, the update service still creates the $APPDIR/updates/0 directory, which is pretty pointless.
This happens because the check for the preference and other information is done after the directory is created in the canUpdate getter.

The attached patch moves these checks around.

Comment 1

[Robert Strong (they/them - no direct email)]

Comment on attachment 421017 [details] [diff] [review]
patch for 1.9.1

Looks fine and thanks

Comment 2

[Robert Strong (they/them - no direct email)]

I believe I already fixed this on trunk and 1.9.2. I doubt you'll get approval for 1.9.1 though you might be able to convince the 1.9.1 drivers.

Comment 3

[Mike Hommey [:glandium]]

As I wrote in comment #0, I only filed for reference. Other linux distros may want to apply it, for example.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 421017 [details] [diff] [review]
patch for 1.9.1

Removing r+ so it doesn't interfere with bugzilla queries

Comment 5

[Reed Loden [:reed]]

Marking WFM based on comment #2.

Comment 6

[Nochum Sossonko [:Natch]]

Comment on attachment 421017 [details] [diff] [review]
patch for 1.9.1

Doesn't hurt to ask...

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 421017 [details] [diff] [review]
patch for 1.9.1

Except the patch doesn't apply anymore

Comment 8

[Mike Hommey [:glandium]]

Attachment: Patch against 1.9.1.10

For those interested.