538965 - MathML mfenced: whitespaces in open/close attributes are not collapsed

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

Attachment: testcase

The MathML REC says:

"The "opening-fence" and "closing-fence" are arbitrary strings. (Since they are used as the content of mo elements, any whitespace they contain will be trimmed and collapsed as described in Section 2.4.6 Collapsing Whitespace in Input.) "

This is not currently the case (see attachment).

Comment 1

[Frédéric Wang (:fredw)]

If someone wants to work on this bug, I guess nsAutoString::CompressWhitespace
 should do the job:

https://developer.mozilla.org/En/NsAutoString#CompressWhitespace

Also, a reftest layout/reftests/mathml/mfenced-2* should be add (see also the related bugs: bug 553918 and bug 537916)

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch a: Make nsMathMLmfencedFrame::CreateFencesAndSeparators return void (v1)

Some preparatory cleanup: now that new is infallible, nsMathMLmfencedFrame::CreateFencesAndSeparators can't fail.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch b: Compress whitespace (v1)

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 466022 [details] [diff] [review]
Patch b: Compress whitespace (v1)

Great, thanks!

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 466022 [details] [diff] [review]
Patch b: Compress whitespace (v1)

Requesting approval for a simple correctness fix, with plenty of reftests.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a for checkin

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b for checkin

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/f325994313ea
http://hg.mozilla.org/mozilla-central/rev/a1705bc179e4