538990 - add a resource manifest to mozilla-runtime.exe

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Jim Mathies [:jimm]]

Attachment: resource patch

Spin off from bug 538918 - some plugins generate common controls based UI (like Flash's print dialog) so we need to add a common controls manifest to the exe to enable newer windows UI.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 421059 [details] [diff] [review]
resource patch

>diff --git a/ipc/app/Makefile.in b/ipc/app/Makefile.in
>--- a/ipc/app/Makefile.in
>+++ b/ipc/app/Makefile.in
>@@ -65,16 +65,20 @@ else
> MOZ_WINCONSOLE = 0
> endif
> endif
> 
> # This switches $(INSTALL) to copy mode, like $(SYSINSTALL), so things that
> # shouldn't get 755 perms need $(IFLAGS1) for either way of calling nsinstall.
> NSDISTMODE = copy
> 
>+ifeq ($(OS_ARCH),WINNT)
>+RCINCLUDE = resource.rc
>+endif
>+

I don't think this should be necessary, our build system should automatically insert the manifest after linking:
http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1006

Did you find that to not be the case?

Comment 2

[Jim Mathies [:jimm]]

(In reply to comment #1)
> >+ifeq ($(OS_ARCH),WINNT)
> >+RCINCLUDE = resource.rc
> >+endif
> >+
> 
> I don't think this should be necessary, our build system should automatically
> insert the manifest after linking:
> http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1006
> 
> Did you find that to not be the case?

I had no idea this was built in to build, let me test to see.

Comment 3

[Jim Mathies [:jimm]]

Attachment: mozilla-runtime manifest

That works too!

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 421289 [details] [diff] [review]
mozilla-runtime manifest

You'll want to include the trustInfo section like the firefox.exe.manifest has:
http://mxr.mozilla.org/mozilla-central/source/browser/app/firefox.exe.manifest

Apparently we can wind up with folder virtualization without that (see bug 378598).

r+ with that added.

Comment 5

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/fbef35548548